-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat(eos_cli_config_gen): Extend GRE span with payload support #4190
Merged
ClausHolbechArista
merged 27 commits into
aristanetworks:devel
from
Vibhu-gslab:monitor_session
Aug 21, 2024
Merged
Feat(eos_cli_config_gen): Extend GRE span with payload support #4190
ClausHolbechArista
merged 27 commits into
aristanetworks:devel
from
Vibhu-gslab:monitor_session
Aug 21, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4190
# Activate the virtual environment
source test-avd-pr-4190/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/Vibhu-gslab/avd.git@monitor_session#subdirectory=python-avd" --force
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/Vibhu-gslab/avd.git#/ansible_collections/arista/avd/,monitor_session --force
# Optional: Install AVD examples
cd test-avd-pr-4190
ansible-playbook arista.avd.install_examples |
github-actions
bot
added
role: eos_cli_config_gen
issue related to eos_cli_config_gen role
state: CI Updated
CI scenario have been updated in the PR
state: Documentation role Updated
labels
Jul 8, 2024
Vibhu-gslab
force-pushed
the
monitor_session
branch
from
July 9, 2024 04:28
c5e2289
to
be8387f
Compare
python-avd/pyavd/_eos_cli_config_gen/j2templates/documentation/monitor-sessions.j2
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_cli_config_gen/j2templates/documentation/monitor-sessions.j2
Show resolved
Hide resolved
python-avd/pyavd/_eos_cli_config_gen/j2templates/documentation/monitor-sessions.j2
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_cli_config_gen/schema/eos_cli_config_gen.schema.yml
Outdated
Show resolved
Hide resolved
Vibhu-gslab
force-pushed
the
monitor_session
branch
from
July 10, 2024 05:13
01c4737
to
380d365
Compare
MaheshGSLAB
reviewed
Jul 10, 2024
python-avd/pyavd/_eos_cli_config_gen/j2templates/documentation/monitor-sessions.j2
Outdated
Show resolved
Hide resolved
...collections/arista/avd/molecule/eos_cli_config_gen/documentation/devices/monitor-sessions.md
Outdated
Show resolved
Hide resolved
...cli_config_gen/schema/schema_fragments/monitor_sessions_default_encapsulation_gre.schema.yml
Outdated
Show resolved
Hide resolved
MaheshGSLAB
approved these changes
Jul 12, 2024
Vibhu-gslab
force-pushed
the
monitor_session
branch
from
July 18, 2024 04:52
28a7c7b
to
3e847a8
Compare
Shivani-gslab
approved these changes
Jul 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
laxmikantchintakindi
approved these changes
Jul 18, 2024
MaheshGSLAB
reviewed
Jul 19, 2024
python-avd/pyavd/_eos_cli_config_gen/j2templates/documentation/monitor-sessions.j2
Outdated
Show resolved
Hide resolved
MaheshGSLAB
reviewed
Jul 19, 2024
python-avd/pyavd/_eos_cli_config_gen/j2templates/eos-intended-config.j2
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_cli_config_gen/j2templates/documentation/monitor-sessions.j2
Outdated
Show resolved
Hide resolved
Vibhu-gslab
force-pushed
the
monitor_session
branch
3 times, most recently
from
July 22, 2024 07:57
0a13fa5
to
f52aa94
Compare
ClausHolbechArista
previously requested changes
Jul 22, 2024
python-avd/pyavd/_eos_cli_config_gen/j2templates/eos/monitor-sessions-default.j2
Outdated
Show resolved
Hide resolved
...on-avd/pyavd/_eos_cli_config_gen/schema/schema_fragments/monitor_sessions_default.schema.yml
Outdated
Show resolved
Hide resolved
for more information, see https://pre-commit.ci
…/monitor-sessions.j2 Co-authored-by: Claus Holbech <holbech@arista.com>
Vibhu-gslab
force-pushed
the
monitor_session
branch
from
August 9, 2024 05:10
a83483d
to
1a40912
Compare
MaheshGSLAB
approved these changes
Aug 9, 2024
laxmikantchintakindi
approved these changes
Aug 19, 2024
Vibhu-gslab
force-pushed
the
monitor_session
branch
from
August 19, 2024 07:47
d575285
to
5ec09a2
Compare
for more information, see https://pre-commit.ci
ClausHolbechArista
added
the
one approval
This PR has one approval and is only missing one more.
label
Aug 21, 2024
ClausHolbechArista
approved these changes
Aug 21, 2024
Quality Gate passedIssues Measures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
one approval
This PR has one approval and is only missing one more.
rn: Feat(eos_cli_config_gen)
role: eos_cli_config_gen
issue related to eos_cli_config_gen role
state: CI Updated
CI scenario have been updated in the PR
state: Documentation role Updated
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
For monitor session default extend GRE span with payload support
Related Issue(s)
Fixes #4160
Component(s) name
arista.avd.eos_cli_config_gen
Proposed changes
Adding support for monitor session default gre
Checklist
Repository Checklist