Fix(eos_cli_config_gen): Fix router_isis rx_disabled and mode: shared-secret #4267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4267
# Activate the virtual environment
source test-avd-pr-4267/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/Vibhu-gslab/avd.git@coverage_router_isis#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/Vibhu-gslab/avd.git#/ansible_collections/arista/avd/,coverage_router_isis --force
# Optional: Install AVD examples
cd test-avd-pr-4267
ansible-playbook arista.avd.install_examples |
github-actions
bot
added
role: eos_cli_config_gen
Vibhu-gslab
force-pushed
the
coverage_router_isis
branch
from
828eceb to
b100036
Compare
github-actions
bot
added
the
state: CI Updated
Vibhu-gslab
force-pushed
the
coverage_router_isis
branch
3 times, most recently
from
95ada21 to
dbb2206
Compare
Vibhu-gslab
requested review from
MaheshGSLAB,
Shivani-gslab and
laxmikantchintakindi
Vibhu-gslab
force-pushed
the
coverage_router_isis
branch
3 times, most recently
from
bc274f1 to
0eaa7d6
Compare
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
laxmikantchintakindi
approved these changes
Aug 1, 2024
Vibhu-gslab
force-pushed
the
coverage_router_isis
branch
from
0ca7a38 to
1ea9ab9
Compare
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
for more information, see https://pre-commit.ci
python-avd/pyavd/_eos_cli_config_gen/schema/schema_fragments/router_isis.schema.yml
Show resolved
Hide resolved
ClausHolbechArista
changed the title
ClausHolbechArista
approved these changes
Aug 5, 2024
|
jrecchia1029
pushed a commit
to jrecchia1029/ansible-avd
that referenced
this pull request
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Added test in molecule for router isis to improve the coverage
Fixing two bugs:
shared_secretas valid_value but the template looked forshared-secret.Component(s) name
arista.avd.eos_cli_config_genHow to test
Run molecule
Checklist
Repository Checklist