Cut(eos_cli_config_gen): Remove deprecated keys address_family and isis_af_defaults from router-isis data model
#4278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4278
# Activate the virtual environment
source test-avd-pr-4278/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/Vibhu-gslab/avd.git@dep_router_isis#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/Vibhu-gslab/avd.git#/ansible_collections/arista/avd/,dep_router_isis --force
# Optional: Install AVD examples
cd test-avd-pr-4278
ansible-playbook arista.avd.install_examples |
github-actions
bot
added
role: eos_cli_config_gen
Vibhu-gslab
changed the title
address_family and isis_af_defaults from router-isis data modeladdress_family and isis_af_defaults from router-isis data model
Vibhu-gslab
requested review from
MaheshGSLAB,
Shivani-gslab and
laxmikantchintakindi
Vibhu-gslab
force-pushed
the
dep_router_isis
branch
2 times, most recently
from
60ba485
to
f490278
Compare
MaheshGSLAB
reviewed
Jul 30, 2024
ansible_collections/arista/avd/roles/eos_cli_config_gen/docs/tables/router-isis.md
Outdated
Show resolved
Hide resolved
MaheshGSLAB
reviewed
Jul 30, 2024
python-avd/pyavd/_eos_cli_config_gen/schema/schema_fragments/router_isis.schema.yml
Show resolved
Hide resolved
github-actions
bot
added
the
type: documentation
Vibhu-gslab
changed the title
address_family and isis_af_defaults from router-isis data modeladdress_family and isis_af_defaults from router-isis data model
ClausHolbechArista
changed the title
address_family and isis_af_defaults from router-isis data modeladdress_family and isis_af_defaults from router-isis data model
MaheshGSLAB
approved these changes
Jul 30, 2024
Vibhu-gslab
force-pushed
the
dep_router_isis
branch
from
20c67b6
to
2c7cc8e
Compare
ClausHolbechArista
requested changes
Jul 31, 2024
python-avd/pyavd/_eos_cli_config_gen/schema/schema_fragments/router_isis.schema.yml
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_cli_config_gen/schema/schema_fragments/router_isis.schema.yml
Outdated
Show resolved
Hide resolved
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Vibhu-gslab
force-pushed
the
dep_router_isis
branch
from
2c7cc8e
to
c514e72
Compare
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
laxmikantchintakindi
approved these changes
Aug 1, 2024
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
ClausHolbechArista
approved these changes
Aug 5, 2024
|
jrecchia1029
pushed a commit
to jrecchia1029/ansible-avd
that referenced
this pull request
Aug 14, 2024
…`isis_af_defaults` from router-isis data model (aristanetworks#4278)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Removing deprecated keys
address_familyandisis_af_defaultsfrom router-isis data modelRelated Issue(s)
Fixes #
Component(s) name
arista.avd.eos_cli_config_genProposed changes
Added removed: true for keys
address_familyandisis_af_defaults, removed the functionality from j2 templateHow to test
CI will check
Checklist
Repository Checklist