-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cut(eos_cli_config_gen): Remove the deprecated keys for event-handlers #4279
Cut(eos_cli_config_gen): Remove the deprecated keys for event-handlers #4279
Conversation
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4279
# Activate the virtual environment
source test-avd-pr-4279/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/Shivani-gslab/avd.git@event_handlers_removed#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/Shivani-gslab/avd.git#/ansible_collections/arista/avd/,event_handlers_removed --force
# Optional: Install AVD examples
cd test-avd-pr-4279
ansible-playbook arista.avd.install_examples |
...ctions/arista/avd/molecule/eos_cli_config_gen_deprecated_vars/documentation/devices/host1.md
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update table in porting guide with the removed key and it's replacement (need to rebase first)
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
We have decided to update release-notes in a separate PR
e70d48f
to
16f85e9
Compare
Conflicts have been resolved. A maintainer will review the pull request shortly. |
16f85e9
to
aed3dc2
Compare
67dd56a
to
0af40f7
Compare
Quality Gate passedIssues Measures |
Change Summary
Remove the deprecated keys for event-handlers.
Related Issue(s)
Fixes #
Component(s) name
arista.avd.eos_cli_config_gen
Proposed changes
Remove the deprecated keys for event-handlers and remove the test from molecule scenario eos_cli_config_gen_deprecated_vars
Checklist
Repository Checklist