Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cut(eos_cli_config_gen): Remove the deprecated keys for event-handlers #4279

Merged

Conversation

Shivani-gslab
Copy link
Contributor

@Shivani-gslab Shivani-gslab commented Jul 29, 2024

Change Summary

Remove the deprecated keys for event-handlers.

Related Issue(s)

Fixes #

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

Remove the deprecated keys for event-handlers and remove the test from molecule scenario eos_cli_config_gen_deprecated_vars

Checklist

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

Copy link

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4279
# Activate the virtual environment
source test-avd-pr-4279/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/Shivani-gslab/avd.git@event_handlers_removed#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/Shivani-gslab/avd.git#/ansible_collections/arista/avd/,event_handlers_removed --force
# Optional: Install AVD examples
cd test-avd-pr-4279
ansible-playbook arista.avd.install_examples

@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated role: eos_designs issue related to eos_designs role labels Jul 29, 2024
@MaheshGSLAB MaheshGSLAB marked this pull request as ready for review July 29, 2024 11:22
@MaheshGSLAB MaheshGSLAB requested review from a team as code owners July 29, 2024 11:22
@MaheshGSLAB MaheshGSLAB requested a review from a team July 29, 2024 11:23
Copy link
Contributor

@ClausHolbechArista ClausHolbechArista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update table in porting guide with the removed key and it's replacement (need to rebase first)

@Shivani-gslab Shivani-gslab marked this pull request as draft July 29, 2024 14:30
@github-actions github-actions bot added the state: conflict PR with conflict label Jul 30, 2024
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@ClausHolbechArista ClausHolbechArista dismissed their stale review July 30, 2024 07:43

We have decided to update release-notes in a separate PR

Copy link

Conflicts have been resolved. A maintainer will review the pull request shortly.

@github-actions github-actions bot removed the state: conflict PR with conflict label Jul 30, 2024
@Shivani-gslab Shivani-gslab marked this pull request as ready for review July 30, 2024 07:54
@github-actions github-actions bot added the type: documentation Improvements or additions to documentation label Jul 30, 2024
Copy link

sonarcloud bot commented Jul 30, 2024

@ClausHolbechArista ClausHolbechArista merged commit 8660b94 into aristanetworks:devel Jul 30, 2024
43 checks passed
@ClausHolbechArista ClausHolbechArista changed the title Refactor(eos_cli_config_gen): Remove the deprecated keys for event-handlers Cut(eos_cli_config_gen): Remove the deprecated keys for event-handlers Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rn: Cut(eos_cli_config_gen) role: eos_cli_config_gen issue related to eos_cli_config_gen role role: eos_designs issue related to eos_designs role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated type: documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants