-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor(eos_designs): Optimize eos_designs_structured_config file write #4283
Merged
ClausHolbechArista
merged 10 commits into
aristanetworks:devel
from
ClausHolbechArista:refactor/eos_designs/optimize-eos_designs_structured_config-file-write
Aug 14, 2024
Merged
Refactor(eos_designs): Optimize eos_designs_structured_config file write #4283
ClausHolbechArista
merged 10 commits into
aristanetworks:devel
from
ClausHolbechArista:refactor/eos_designs/optimize-eos_designs_structured_config-file-write
Aug 14, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4283
# Activate the virtual environment
source test-avd-pr-4283/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/ClausHolbechArista/avd.git@refactor/eos_designs/optimize-eos_designs_structured_config-file-write#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/ClausHolbechArista/avd.git#/ansible_collections/arista/avd/,refactor/eos_designs/optimize-eos_designs_structured_config-file-write --force
# Optional: Install AVD examples
cd test-avd-pr-4283
ansible-playbook arista.avd.install_examples |
…tructured_config-file-write
…tructured_config-file-write
gmuloc
reviewed
Jul 30, 2024
ansible_collections/arista/avd/plugins/action/eos_designs_structured_config.py
Outdated
Show resolved
Hide resolved
ansible_collections/arista/avd/plugins/action/eos_designs_structured_config.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Guillaume Mulocher <gmulocher@arista.com>
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
…tructured_config-file-write
Conflicts have been resolved. A maintainer will review the pull request shortly. |
ClausHolbechArista
requested review from
a team,
Vibhu-gslab,
MaheshGSLAB,
Shivani-gslab and
laxmikantchintakindi
August 5, 2024 11:30
…tructured_config-file-write
Vibhu-gslab
reviewed
Aug 6, 2024
ansible_collections/arista/avd/plugins/action/eos_designs_structured_config.py
Outdated
Show resolved
Hide resolved
…ctured_config.py Co-authored-by: Vibhu-gslab <109593615+Vibhu-gslab@users.noreply.github.com>
…tructured_config-file-write
…tructured_config-file-write
MaheshGSLAB
approved these changes
Aug 13, 2024
Shivani-gslab
approved these changes
Aug 14, 2024
…tructured_config-file-write
Quality Gate passedIssues Measures |
ClausHolbechArista
deleted the
refactor/eos_designs/optimize-eos_designs_structured_config-file-write
branch
August 20, 2024 11:33
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Optimize eos_designs_structured_config file write
Component(s) name
arista.avd.eos_designs
Proposed changes
How to test
Tested locally with both yml, yaml and json files.
Checklist
User Checklist
Repository Checklist