Cut(eos_cli_config_gen): Remove deprecated key MIB_family_name from snmp_server data model #4289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
role: eos_cli_config_gen
|
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4289
# Activate the virtual environment
source test-avd-pr-4289/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/laxmikantchintakindi/avd.git@snmp_server_deprecated#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/laxmikantchintakindi/avd.git#/ansible_collections/arista/avd/,snmp_server_deprecated --force
# Optional: Install AVD examples
cd test-avd-pr-4289
ansible-playbook arista.avd.install_examples |
github-actions
bot
added
the
type: documentation
Vibhu-gslab
previously requested changes
Jul 30, 2024
ClausHolbechArista
changed the title
ClausHolbechArista
changed the title
ClausHolbechArista
changed the title
laxmikantchintakindi
force-pushed
the
snmp_server_deprecated
branch
from
87ca360
to
5d9a078
Compare
ClausHolbechArista
requested changes
Jul 30, 2024
...ta/avd/molecule/eos_cli_config_gen_deprecated_vars/inventory/host_vars/host1/snmp-server.yml
Show resolved
Hide resolved
python-avd/pyavd/_eos_cli_config_gen/schema/schema_fragments/snmp_server.schema.yml
Show resolved
Hide resolved
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
added 2 commits
July 31, 2024 10:37
…removed in snmp_server data model
laxmikantchintakindi
force-pushed
the
snmp_server_deprecated
branch
from
5d9a078
to
82d5a09
Compare
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
|
ClausHolbechArista
approved these changes
Jul 31, 2024
ClausHolbechArista
added
the
one approval
gmuloc
approved these changes
Jul 31, 2024
jrecchia1029
pushed a commit
to jrecchia1029/ansible-avd
that referenced
this pull request
Aug 14, 2024
…nmp_server data model (aristanetworks#4289)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Mark deprecated key MIB_family_name as removed in snmp_server data model.
Related Issue(s)
Component(s) name
arista.avd.eos_cli_config_genProposed changes
Mark deprecated key MIB_family_name as removed in snmp_server data model. Remove the code for deprecated key from eos and documentation templates.
How to test
Checklist
User Checklist
Repository Checklist