Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ip/v6 static routes documentation and metric #429

Merged
merged 2 commits into from
Dec 8, 2020

Conversation

xaviramon
Copy link
Contributor

@xaviramon xaviramon commented Dec 7, 2020

Change Summary

  1. IPv4 static routes documentation increased with missing variables.
  2. IPv6 static routes documentation developed based on IPv4.
  3. IPv4 and IPv6 metric EOS command included.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Documentation content changes
  • Other (please describe):

Related Issue(s)

Fixes #278

Component(s) name

Proposed changes

How to test

Checklist:

  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed (pre-commit, make linting and make sanity-lint).
  • I have updated molecule CI testing accordingly

@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role type: documentation Improvements or additions to documentation labels Dec 7, 2020
@titom73 titom73 self-requested a review December 7, 2020 18:47
@github-actions github-actions bot added the state: CI Updated CI scenario have been updated in the PR label Dec 7, 2020
Copy link
Contributor

@titom73 titom73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@titom73 titom73 merged commit 7b106d9 into aristanetworks:devel Dec 8, 2020
@titom73 titom73 modified the milestones: v1.1.3, v1.1.2 Dec 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR type: documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Static Routes Device Documentation Template to be completed
2 participants