Cut(eos_cli_config_gen): Remove the deprecated keys for name-server #4290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4290
# Activate the virtual environment
source test-avd-pr-4290/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/MaheshGSLAB/ansible-avd.git@name-server#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/MaheshGSLAB/ansible-avd.git#/ansible_collections/arista/avd/,name-server --force
# Optional: Install AVD examples
cd test-avd-pr-4290
ansible-playbook arista.avd.install_examples |
github-actions
bot
added
type: documentation
ClausHolbechArista
changed the title
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
Vibhu-gslab
reviewed
Jul 31, 2024
python-avd/pyavd/_eos_cli_config_gen/j2templates/documentation/management.j2
Show resolved
Hide resolved
Vibhu-gslab
approved these changes
Jul 31, 2024
laxmikantchintakindi
approved these changes
Jul 31, 2024
ClausHolbechArista
previously requested changes
Jul 31, 2024
python-avd/pyavd/_eos_cli_config_gen/schema/schema_fragments/name_server.schema.yml
Show resolved
Hide resolved
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
github-actions
bot
added
state: conflict
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
|
jrecchia1029
pushed a commit
to jrecchia1029/ansible-avd
that referenced
this pull request
Aug 14, 2024
…ristanetworks#4290) Co-authored-by: gmuloc <gmulocher@arista.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Remove the deprecated keys for name-server
Related Issue(s)
Fixes #
Component(s) name
`arista.avd.eos_cli_config_gen
Proposed changes
Remove the deprecated keys for name-server and remove the test from molecule scenario eos_cli_config_gen_deprecated_vars
How to test
Run molecule
Checklist
User Checklist
Repository Checklist