-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cut: Remove deprecated Ansible plugins #4291
Merged
ClausHolbechArista
merged 16 commits into
aristanetworks:devel
from
ClausHolbechArista:cut/deprecated-plugins
Aug 2, 2024
Merged
Cut: Remove deprecated Ansible plugins #4291
ClausHolbechArista
merged 16 commits into
aristanetworks:devel
from
ClausHolbechArista:cut/deprecated-plugins
Aug 2, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4291
# Activate the virtual environment
source test-avd-pr-4291/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/ClausHolbechArista/avd.git@cut/deprecated-plugins#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/ClausHolbechArista/avd.git#/ansible_collections/arista/avd/,cut/deprecated-plugins --force
# Optional: Install AVD examples
cd test-avd-pr-4291
ansible-playbook arista.avd.install_examples |
github-actions
bot
added
type: documentation
Improvements or additions to documentation
type: code quality
CI and development toolset
state: CI Updated
CI scenario have been updated in the PR
type: Python filters
labels
Jul 30, 2024
gmuloc
requested changes
Aug 1, 2024
gmuloc
approved these changes
Aug 1, 2024
gmuloc
added
the
one approval
This PR has one approval and is only missing one more.
label
Aug 1, 2024
Quality Gate passedIssues Measures |
jrecchia1029
pushed a commit
to jrecchia1029/ansible-avd
that referenced
this pull request
Aug 14, 2024
Co-authored-by: Guillaume Mulocher <gmulocher@arista.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
one approval
This PR has one approval and is only missing one more.
rn: Cut
state: CI Updated
CI scenario have been updated in the PR
type: code quality
CI and development toolset
type: documentation
Improvements or additions to documentation
type: Python filters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Remove deprecated Ansible plugins
Related Issue(s)
Fixes #
Component(s) name
arista.avd.<role-name>
Proposed changes
arista.avd.hash_passphrase
arista.avd.snmp_hash
insteadarista.avd.generate_esi
{{ <esi_prefix> ~ <short_esi> }}
arista.avd.generate_lacp_id
replace
filter instead like{{ <short_esi> | replace(':', '.') }}
arista.avd.generate_route_target
ansible.builtin.regex_replace
filter instead like{{ <short_esi> | ansible.builtin.regex_replace('(\\d{2})(\\d{2}):(\\d{2})(\\d{2}):(\\d{2})(\\d{2})', '\\1:\\2:\\3:\\4:\\5:\\6') }}
arista.avd.deploy_to_cv
arista.avd.cv_workflow
insteadarista.avd.batch_template
arista.avd.batch_template
action plugin is no longer used by AVD. The plugin is released as open source, so it can be copied and reused according to the license and copyright.arista.avd.validate_and_template
arista.avd.validate_and_template
action plugin is no longer used by AVD. The plugin is released as open source, so it can be copied and reused according to the license and copyright.arista.avd.yaml_templates_to_facts
arista.avd.yaml_templates_to_facts
action plugin is no longer used by AVD. The plugin is released as open source, so it can be copied and reused according to the license and copyright.How to test
CI should pass. Since they were unused we should not see any changes.
Checklist
User Checklist
Repository Checklist