Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cut: Remove deprecated Ansible plugins #4291

Conversation

ClausHolbechArista
Copy link
Contributor

Change Summary

Remove deprecated Ansible plugins

Related Issue(s)

Fixes #

Component(s) name

arista.avd.<role-name>

Proposed changes

Plugin type Plugin name Replacement
Filter arista.avd.hash_passphrase Use arista.avd.snmp_hash instead
Filter arista.avd.generate_esi Use Jinja string concatenation instead like {{ <esi_prefix> ~ <short_esi> }}
Filter arista.avd.generate_lacp_id Use the builtin replace filter instead like {{ <short_esi> | replace(':', '.') }}
Filter arista.avd.generate_route_target Use the builtin ansible.builtin.regex_replace filter instead like {{ <short_esi> | ansible.builtin.regex_replace('(\\d{2})(\\d{2}):(\\d{2})(\\d{2}):(\\d{2})(\\d{2})', '\\1:\\2:\\3:\\4:\\5:\\6') }}
Action plugin/Module arista.avd.deploy_to_cv Use arista.avd.cv_workflow instead
Action plugin/Module arista.avd.batch_template The internal arista.avd.batch_template action plugin is no longer used by AVD. The plugin is released as open source, so it can be copied and reused according to the license and copyright.
Action plugin/Module arista.avd.validate_and_template The internal arista.avd.validate_and_template action plugin is no longer used by AVD. The plugin is released as open source, so it can be copied and reused according to the license and copyright.
Action plugin/Module arista.avd.yaml_templates_to_facts The internal arista.avd.yaml_templates_to_facts action plugin is no longer used by AVD. The plugin is released as open source, so it can be copied and reused according to the license and copyright.
  • Cleaning up docs and other references to the modules
  • Tombstone in meta file for Ansible collection

How to test

CI should pass. Since they were unused we should not see any changes.

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@ClausHolbechArista ClausHolbechArista requested review from a team as code owners July 30, 2024 12:39
Copy link

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4291
# Activate the virtual environment
source test-avd-pr-4291/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/ClausHolbechArista/avd.git@cut/deprecated-plugins#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/ClausHolbechArista/avd.git#/ansible_collections/arista/avd/,cut/deprecated-plugins --force
# Optional: Install AVD examples
cd test-avd-pr-4291
ansible-playbook arista.avd.install_examples

@github-actions github-actions bot added type: documentation Improvements or additions to documentation type: code quality CI and development toolset state: CI Updated CI scenario have been updated in the PR type: Python filters labels Jul 30, 2024
@gmuloc gmuloc added the one approval This PR has one approval and is only missing one more. label Aug 1, 2024
@gmuloc gmuloc added this to the v5.0.0-dev1 milestone Aug 1, 2024
@gmuloc gmuloc requested a review from a team August 1, 2024 12:46
Copy link

sonarcloud bot commented Aug 2, 2024

@ClausHolbechArista ClausHolbechArista merged commit 4d72da2 into aristanetworks:devel Aug 2, 2024
45 checks passed
jrecchia1029 pushed a commit to jrecchia1029/ansible-avd that referenced this pull request Aug 14, 2024
Co-authored-by: Guillaume Mulocher <gmulocher@arista.com>
@ClausHolbechArista ClausHolbechArista deleted the cut/deprecated-plugins branch August 20, 2024 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
one approval This PR has one approval and is only missing one more. rn: Cut state: CI Updated CI scenario have been updated in the PR type: code quality CI and development toolset type: documentation Improvements or additions to documentation type: Python filters
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants