Cut(eos_cli_config_gen): Remove deprecated keys enable_vrfs and octa from management_api_gnmi data model #4296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4296
# Activate the virtual environment
source test-avd-pr-4296/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/Vibhu-gslab/avd.git@dep_management_api_gnmi#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/Vibhu-gslab/avd.git#/ansible_collections/arista/avd/,dep_management_api_gnmi --force
# Optional: Install AVD examples
cd test-avd-pr-4296
ansible-playbook arista.avd.install_examples |
github-actions
bot
added
type: documentation
Vibhu-gslab
changed the title
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
MaheshGSLAB
reviewed
Jul 31, 2024
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
python-avd/pyavd/_eos_cli_config_gen/j2templates/documentation/management-api-gnmi.j2
Outdated
Show resolved
Hide resolved
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
… from management_api_gnmi data model
Co-authored-by: Mahesh Kumar <122076792+MaheshGSLAB@users.noreply.github.com>
…/management-api-gnmi.j2 Co-authored-by: laxmikantchintakindi <159624484+laxmikantchintakindi@users.noreply.github.com>
Vibhu-gslab
force-pushed
the
dep_management_api_gnmi
branch
from
2c80957
to
0fb403d
Compare
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
laxmikantchintakindi
approved these changes
Aug 1, 2024
|
We can remove lines 124-139 from schema file and its documentation. |
|
line 148 too. |
MaheshGSLAB
previously requested changes
Aug 1, 2024
|
jrecchia1029
pushed a commit
to jrecchia1029/ansible-avd
that referenced
this pull request
Aug 14, 2024
…from management_api_gnmi data model (aristanetworks#4296) Co-authored-by: Guillaume Mulocher <gmulocher@arista.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Remove deprecated keys enable_vrfs and octa from management_api_gnmi data model
Related Issue(s)
Fixes #
Component(s) name
arista.avd.eos_cli_config_genProposed changes
added removed: true in schema and removed j2 code also made modifications to deprecated_vars molecule
Checklist
Repository Checklist