-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cut(eos_cli_config_gen): Remove the deprecated keys for port-channel-interfaces #4297
Conversation
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4297
# Activate the virtual environment
source test-avd-pr-4297/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/MaheshGSLAB/ansible-avd.git@port-channel#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/MaheshGSLAB/ansible-avd.git#/ansible_collections/arista/avd/,port-channel --force
# Optional: Install AVD examples
cd test-avd-pr-4297
ansible-playbook arista.avd.install_examples |
python-avd/pyavd/_eos_cli_config_gen/j2templates/eos/port-channel-interfaces.j2
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_cli_config_gen/schema/schema_fragments/port_channel_interfaces.schema.yml
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_cli_config_gen/schema/schema_fragments/port_channel_interfaces.schema.yml
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_cli_config_gen/j2templates/documentation/port-channel-interfaces.j2
Show resolved
Hide resolved
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Conflicts have been resolved. A maintainer will review the pull request shortly. |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Conflicts have been resolved. A maintainer will review the pull request shortly. |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
aab0f7b
to
39faa0a
Compare
Conflicts have been resolved. A maintainer will review the pull request shortly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
f1223e8
to
cdd515a
Compare
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
…nel-interfaces.j2 Co-authored-by: Claus Holbech <holbech@arista.com>
Co-authored-by: Claus Holbech <holbech@arista.com>
c76ad20
to
263b14d
Compare
Conflicts have been resolved. A maintainer will review the pull request shortly. |
comments have been addressed
Quality Gate passedIssues Measures |
…interfaces (aristanetworks#4297) Co-authored-by: Carl Buchmann <carl.buchmann@arista.com> Co-authored-by: Claus Holbech <holbech@arista.com>
Change Summary
Remove the deprecated keys for port-channel-interfaces
Related Issue(s)
Fixes #
Component(s) name
arista.avd.eos_cli_config_gen
Proposed changes
Remove the deprecated keys for port-channel-interfaces
How to test
Run molecule
Checklist
User Checklist
Repository Checklist