-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cut(eos_cli_config_gen): Remove automatic conversion of dict-of-dicts to lists #4320
Cut(eos_cli_config_gen): Remove automatic conversion of dict-of-dicts to lists #4320
Conversation
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4320
# Activate the virtual environment
source test-avd-pr-4320/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/ClausHolbechArista/avd.git@cut/eos_cli_config_gen/convert-dicts#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/ClausHolbechArista/avd.git#/ansible_collections/arista/avd/,cut/eos_cli_config_gen/convert-dicts --force
# Optional: Install AVD examples
cd test-avd-pr-4320
ansible-playbook arista.avd.install_examples |
01c192f
to
3a4e689
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Checked with deleted tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Quality Gate passedIssues Measures |
Change Summary
Remove automatic conversion of dict-of-dicts to lists
Component(s) name
arista.avd.eos_cli_config_gen
Proposed changes
convert_types
How to test
Tested with old models and saw errors being raised.
No errors when input of correct models.
Checklist
User Checklist
Repository Checklist