Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cut(eos_cli_config_gen): Remove automatic conversion of dict-of-dicts to lists #4320

Conversation

ClausHolbechArista
Copy link
Contributor

Change Summary

Remove automatic conversion of dict-of-dicts to lists

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

  • Remove dict type from schema convert_types
  • Update release-notes and porting-guide
  • Remove tests of conversion from deprecated vars
  • Update templates

How to test

Tested with old models and saw errors being raised.
No errors when input of correct models.

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@ClausHolbechArista ClausHolbechArista requested review from a team as code owners August 5, 2024 12:12
Copy link

github-actions bot commented Aug 5, 2024

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4320
# Activate the virtual environment
source test-avd-pr-4320/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/ClausHolbechArista/avd.git@cut/eos_cli_config_gen/convert-dicts#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/ClausHolbechArista/avd.git#/ansible_collections/arista/avd/,cut/eos_cli_config_gen/convert-dicts --force
# Optional: Install AVD examples
cd test-avd-pr-4320
ansible-playbook arista.avd.install_examples

@github-actions github-actions bot added the type: documentation Improvements or additions to documentation label Aug 5, 2024
@github-actions github-actions bot added the state: CI Updated CI scenario have been updated in the PR label Aug 5, 2024
@ClausHolbechArista ClausHolbechArista force-pushed the cut/eos_cli_config_gen/convert-dicts branch from 01c192f to 3a4e689 Compare August 5, 2024 12:38
Copy link
Contributor

@Shivani-gslab Shivani-gslab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Checked with deleted tests.

Copy link
Contributor

@MaheshGSLAB MaheshGSLAB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

sonarcloud bot commented Aug 6, 2024

@ClausHolbechArista ClausHolbechArista merged commit 2f5e228 into aristanetworks:devel Aug 6, 2024
43 checks passed
jrecchia1029 pushed a commit to jrecchia1029/ansible-avd that referenced this pull request Aug 14, 2024
@ClausHolbechArista ClausHolbechArista deleted the cut/eos_cli_config_gen/convert-dicts branch August 20, 2024 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rn: Cut(eos_cli_config_gen) state: CI Updated CI scenario have been updated in the PR type: documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove support for automatic conversion from dict-of-dicts to list-of-dicts
3 participants