Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(eos_cli_config_gen): Add support for additional isis authentication commands in ethernet-interfaces #4326

Merged
merged 50 commits into from
Nov 15, 2024
Merged

Feat(eos_cli_config_gen): Add support for additional isis authentication commands in ethernet-interfaces #4326

merged 50 commits into from
Nov 15, 2024

Conversation

laxmikantchintakindi
Copy link
Contributor

@laxmikantchintakindi laxmikantchintakindi commented Aug 7, 2024 •
edited
Loading

Change Summary

Deprecate current isis authentication and enhance the feature under a new key

Related Issue(s)

Fixes #

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

Enhance the isis authentication feature by supporting additional commands.
e.g.

interface Ethernet78
   description isis authentication l1 l2 shared secret rx
   isis authentication mode shared-secret profile profile1 algorithm sha-256 rx-disabled

How to test

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 7, 2024

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4326
# Activate the virtual environment
source test-avd-pr-4326/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/laxmikantchintakindi/avd.git@feat/ethernet_interfaces/isis_auth#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/laxmikantchintakindi/avd.git#/ansible_collections/arista/avd/,feat/ethernet_interfaces/isis_auth --force
# Optional: Install AVD examples
cd test-avd-pr-4326
ansible-playbook arista.avd.install_examples

@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated labels Aug 7, 2024
@laxmikantchintakindi laxmikantchintakindi changed the title Feat(eos_cli_config_gen): Deprecate current isis authentication and enhance the feature under a new key Feat(eos_cli_config_gen): Deprecate current keys for isis authentication and enhance the feature under a new key Aug 7, 2024
@Shivani-gslab Shivani-gslab changed the title Feat(eos_cli_config_gen): Deprecate current keys for isis authentication and enhance the feature under a new key Feat(eos_cli_config_gen): Deprecate current keys for ethernet-interfaces isis authentication under and enhance the feature under a new key Aug 7, 2024
@Shivani-gslab Shivani-gslab changed the title Feat(eos_cli_config_gen): Deprecate current keys for ethernet-interfaces isis authentication under and enhance the feature under a new key Feat(eos_cli_config_gen): Deprecate current keys for ethernet-interfaces isis authentication and enhance the feature under a new key Aug 7, 2024
@Vibhu-gslab Vibhu-gslab force-pushed the feat/ethernet_interfaces/isis_auth branch from dc423d1 to 541977d Compare August 7, 2024 09:28
@laxmikantchintakindi laxmikantchintakindi force-pushed the feat/ethernet_interfaces/isis_auth branch 2 times, most recently from edb5216 to 18c5166 Compare August 8, 2024 12:18
@laxmikantchintakindi laxmikantchintakindi marked this pull request as ready for review August 12, 2024 13:11
@laxmikantchintakindi laxmikantchintakindi requested review from a team as code owners August 12, 2024 13:11
@laxmikantchintakindi laxmikantchintakindi changed the title Feat(eos_cli_config_gen): Deprecate current keys for ethernet-interfaces isis authentication and enhance the feature under a new key Feat(eos_cli_config_gen): Add support for additional isis authentication commands in ethernet-interfaces Aug 13, 2024
@laxmikantchintakindi laxmikantchintakindi force-pushed the feat/ethernet_interfaces/isis_auth branch from 3194c97 to c182caf Compare August 16, 2024 08:16
@github-actions github-actions bot added the state: conflict PR with conflict label Aug 16, 2024
@github-actions GitHub Actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@laxmikantchintakindi laxmikantchintakindi marked this pull request as draft August 20, 2024 09:37
@laxmikantchintakindi laxmikantchintakindi force-pushed the feat/ethernet_interfaces/isis_auth branch from d9d656d to 041a28b Compare August 20, 2024 14:21
@github-actions github-actions bot removed the state: conflict PR with conflict label Aug 20, 2024
@github-actions GitHub Actions
Copy link

Conflicts have been resolved. A maintainer will review the pull request shortly.

@laxmikantchintakindi laxmikantchintakindi force-pushed the feat/ethernet_interfaces/isis_auth branch from bd71fe6 to c916935 Compare August 21, 2024 04:17
@laxmikantchintakindi laxmikantchintakindi marked this pull request as ready for review August 21, 2024 04:19
MaheshGSLAB
MaheshGSLAB reviewed Aug 21, 2024
View reviewed changes
python-avd/pyavd/_eos_cli_config_gen/schema/schema_fragments/ethernet_interfaces.schema.yml Show resolved Hide resolved
python-avd/pyavd/_eos_cli_config_gen/j2templates/eos/ethernet-interfaces.j2 Outdated Show resolved Hide resolved
python-avd/pyavd/_eos_cli_config_gen/j2templates/eos/ethernet-interfaces.j2 Outdated Show resolved Hide resolved
python-avd/pyavd/_eos_cli_config_gen/j2templates/eos/ethernet-interfaces.j2 Outdated Show resolved Hide resolved
python-avd/pyavd/_eos_cli_config_gen/j2templates/eos/ethernet-interfaces.j2 Outdated Show resolved Hide resolved
python-avd/pyavd/_eos_cli_config_gen/j2templates/eos/ethernet-interfaces.j2 Outdated Show resolved Hide resolved
python-avd/pyavd/_eos_cli_config_gen/j2templates/eos/ethernet-interfaces.j2 Outdated Show resolved Hide resolved
@ClausHolbechArista ClausHolbechArista dismissed stale reviews from gmuloc and Shivani-gslab November 6, 2024 13:49

Comments addressed

@github-actions github-actions bot added the state: conflict PR with conflict label Nov 11, 2024
@github-actions GitHub Actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the state: conflict PR with conflict label Nov 11, 2024
@github-actions GitHub Actions
Copy link

Conflicts have been resolved. A maintainer will review the pull request shortly.

@gmuloc gmuloc removed this from the v5.1.0-dev2 milestone Nov 13, 2024
@ClausHolbechArista ClausHolbechArista added the one approval This PR has one approval and is only missing one more. label Nov 13, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@ClausHolbechArista ClausHolbechArista merged commit b53e79a into aristanetworks:devel Nov 15, 2024
46 checks passed
ashenoy-arista pushed a commit to ashenoy-arista/avd that referenced this pull request Nov 21, 2024
@laxmikantchintakindi @ashenoy-arista
Feat(eos_cli_config_gen): Add support for additional isis authenticat…
33f2186 
…ion commands in `ethernet-interfaces` (aristanetworks#4326)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ClausHolbechArista ClausHolbechArista ClausHolbechArista approved these changes

@Vibhu-gslab Vibhu-gslab Vibhu-gslab approved these changes

@MaheshGSLAB MaheshGSLAB MaheshGSLAB approved these changes

@Shivani-gslab Shivani-gslab Awaiting requested review from Shivani-gslab

@gmuloc gmuloc Awaiting requested review from gmuloc

Assignees

@laxmikantchintakindi laxmikantchintakindi

Labels
one approval This PR has one approval and is only missing one more. rn: Feat(eos_cli_config_gen) role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@laxmikantchintakindi @Shivani-gslab @gmuloc @ClausHolbechArista @Vibhu-gslab @MaheshGSLAB