Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update documentation templates to remove duplicate line #435

Merged
merged 3 commits into from
Dec 8, 2020
Merged

Update documentation templates to remove duplicate line #435

merged 3 commits into from
Dec 8, 2020

Conversation

titom73
Copy link
Contributor

@titom73 titom73 commented Dec 8, 2020

Change Summary

  • Remove blank line when conditions are not met
  • Set default message when missing
  • Fix some rendering issues

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Documentation content changes
  • Other (please describe):

Related Issue(s)

Fixes issue #428

Component(s) name

eos_cli_config_gen

Proposed changes

How to test

Run molecule scenario

Checklist:

  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed (pre-commit, make linting and make sanity-lint).
  • I have updated molecule CI testing accordingly

@titom73
Update documentation templates as per #428
a5c29f7 
- Remove blank line when conditions are not met
- Set default message when missing
- Fix some rendering issues
@titom73
Update CI artifacts
cf0d71d
@titom73 titom73 self-assigned this Dec 8, 2020
@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR type: documentation Improvements or additions to documentation labels Dec 8, 2020
@aphillipps
Copy link
Contributor

LGTM

aphillipps
aphillipps approved these changes Dec 8, 2020
View reviewed changes
Copy link
Contributor

@aphillipps aphillipps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@titom73 titom73 merged commit 7dc2db2 into aristanetworks:devel Dec 8, 2020
@titom73 titom73 deleted the issues/428 branch December 8, 2020 17:36
@titom73 titom73 linked an issue Dec 9, 2020 that may be closed by this pull request
Blank Lines in eos_cli_con_gen device documentation #428
Closed
@titom73 titom73 mentioned this pull request Dec 9, 2020
Closed
@titom73 titom73 added this to the v1.1.2 milestone Dec 10, 2020
@titom73 titom73 mentioned this pull request Feb 15, 2022
Merged
@titom73 titom73 mentioned this pull request Mar 7, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aphillipps aphillipps aphillipps approved these changes

Assignees

@titom73 titom73

Labels
role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR type: documentation Improvements or additions to documentation
Projects
None yet
Milestone
v1.1.2
Development

Successfully merging this pull request may close these issues.

Blank Lines in eos_cli_con_gen device documentation
2 participants
@titom73 @aphillipps