Feat(eos_cli_config_gen): Add support for additional modes and feature in isis authentication under port-channel-interfaces
#4353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4353
# Activate the virtual environment
source test-avd-pr-4353/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/laxmikantchintakindi/avd.git@feat/port_channel_interfaces/isis_auth#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/laxmikantchintakindi/avd.git#/ansible_collections/arista/avd/,feat/port_channel_interfaces/isis_auth --force
# Optional: Install AVD examples
cd test-avd-pr-4353
ansible-playbook arista.avd.install_examples |
github-actions
bot
added
role: eos_cli_config_gen
laxmikantchintakindi
changed the title
laxmikantchintakindi
changed the title
port-channel-interfaces
laxmikantchintakindi
force-pushed
the
feat/port_channel_interfaces/isis_auth
branch
2 times, most recently
from
d7ad356
to
4fed31c
Compare
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
…ture in isis authentication.
for more information, see https://pre-commit.ci
laxmikantchintakindi
force-pushed
the
feat/port_channel_interfaces/isis_auth
branch
from
e5b0e2d
to
3114aec
Compare
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
laxmikantchintakindi
force-pushed
the
feat/port_channel_interfaces/isis_auth
branch
from
3114aec
to
6451e3e
Compare
laxmikantchintakindi
force-pushed
the
feat/port_channel_interfaces/isis_auth
branch
from
58b0e77
to
4f9bebe
Compare
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
ClausHolbechArista
requested changes
Nov 11, 2024
python-avd/pyavd/_eos_cli_config_gen/j2templates/documentation/port-channel-interfaces.j2
Outdated
Show resolved
Hide resolved
ClausHolbechArista
approved these changes
Nov 13, 2024
ClausHolbechArista
added
the
one approval
MaheshGSLAB
reviewed
Nov 14, 2024
python-avd/pyavd/_eos_cli_config_gen/j2templates/documentation/port-channel-interfaces.j2
Outdated
Show resolved
Hide resolved
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
MaheshGSLAB
approved these changes
Nov 15, 2024
Vibhu-gslab
requested changes
Nov 15, 2024
for more information, see https://pre-commit.ci
Added |
Vibhu-gslab
reviewed
Nov 15, 2024
...ctions/arista/avd/molecule/eos_cli_config_gen_deprecated_vars/documentation/devices/dummy.md
Outdated
Show resolved
Hide resolved
|
ashenoy-arista
pushed a commit
to ashenoy-arista/avd
that referenced
this pull request
Nov 21, 2024
…e in isis authentication under `port-channel-interfaces` (aristanetworks#4353)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Add support for additional modes and feature in isis authentication.
Related Issue(s)
Fixes #
Component(s) name
arista.avd.eos_cli_config_genProposed changes
Add support for additional modes and feature in isis authentication.
How to test
Checklist
User Checklist
Repository Checklist