-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor(eos_cli_config_gen)!: Removing default type: switched from ethernet and port-channel interfaces #4355
Merged
ClausHolbechArista
merged 3 commits into
aristanetworks:devel
from
Shivani-gslab:remove_default_type_switched
Aug 13, 2024
Merged
Refactor(eos_cli_config_gen)!: Removing default type: switched from ethernet and port-channel interfaces #4355
ClausHolbechArista
merged 3 commits into
aristanetworks:devel
from
Shivani-gslab:remove_default_type_switched
Aug 13, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4355
# Activate the virtual environment
source test-avd-pr-4355/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/Shivani-gslab/avd.git@remove_default_type_switched#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/Shivani-gslab/avd.git#/ansible_collections/arista/avd/,remove_default_type_switched --force
# Optional: Install AVD examples
cd test-avd-pr-4355
ansible-playbook arista.avd.install_examples |
Shivani-gslab
force-pushed
the
remove_default_type_switched
branch
from
August 13, 2024 07:03
eaae07b
to
f6d703a
Compare
github-actions
bot
added
the
state: CI Updated
CI scenario have been updated in the PR
label
Aug 13, 2024
Shivani-gslab
force-pushed
the
remove_default_type_switched
branch
from
August 13, 2024 07:09
f6d703a
to
17fc6e5
Compare
…hernet and port-channel interfaces
Shivani-gslab
force-pushed
the
remove_default_type_switched
branch
from
August 13, 2024 07:09
17fc6e5
to
3de2caf
Compare
ClausHolbechArista
changed the title
Refactor(eos_cli_config_gen): Removing default type: switched from ethernet and port-channel interfaces
Refactor(eos_cli_config_gen)!: Removing default type: switched from ethernet and port-channel interfaces
Aug 13, 2024
Shivani-gslab
force-pushed
the
remove_default_type_switched
branch
from
August 13, 2024 07:36
38bc17a
to
8d2307b
Compare
Shivani-gslab
force-pushed
the
remove_default_type_switched
branch
from
August 13, 2024 07:45
8d2307b
to
9a580a5
Compare
..._collections/arista/avd/molecule/eos_cli_config_gen/documentation/devices/router-isis-new.md
Show resolved
Hide resolved
Shivani-gslab
force-pushed
the
remove_default_type_switched
branch
2 times, most recently
from
August 13, 2024 10:24
a3303ba
to
2fc24d7
Compare
Shivani-gslab
force-pushed
the
remove_default_type_switched
branch
from
August 13, 2024 10:34
2fc24d7
to
466f403
Compare
Quality Gate passedIssues Measures |
ClausHolbechArista
approved these changes
Aug 13, 2024
ClausHolbechArista
added
the
one approval
This PR has one approval and is only missing one more.
label
Aug 13, 2024
laxmikantchintakindi
approved these changes
Aug 13, 2024
4 tasks
jrecchia1029
pushed a commit
to jrecchia1029/ansible-avd
that referenced
this pull request
Aug 14, 2024
…thernet and port-channel interfaces (aristanetworks#4355)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
one approval
This PR has one approval and is only missing one more.
rn: Refactor(eos_cli_config_gen)!
state: CI Updated
CI scenario have been updated in the PR
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Removing default type: switched from ethernet and port-channel interfaces.
Related Issue(s)
Fixes #
Component(s) name
arista.avd.eos_cli_config_gen
Proposed changes
How to test
Checklist
User Checklist
Repository Checklist