Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor(eos_cli_config_gen)!: Removing default type: switched from ethernet and port-channel interfaces #4355

Conversation

Shivani-gslab
Copy link
Contributor

@Shivani-gslab Shivani-gslab commented Aug 13, 2024

Change Summary

Removing default type: switched from ethernet and port-channel interfaces.

Related Issue(s)

Fixes #

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

How to test

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

Copy link

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4355
# Activate the virtual environment
source test-avd-pr-4355/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/Shivani-gslab/avd.git@remove_default_type_switched#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/Shivani-gslab/avd.git#/ansible_collections/arista/avd/,remove_default_type_switched --force
# Optional: Install AVD examples
cd test-avd-pr-4355
ansible-playbook arista.avd.install_examples

@github-actions github-actions bot added the state: CI Updated CI scenario have been updated in the PR label Aug 13, 2024
@Shivani-gslab Shivani-gslab marked this pull request as ready for review August 13, 2024 07:04
@Shivani-gslab Shivani-gslab requested review from a team as code owners August 13, 2024 07:04
@ClausHolbechArista ClausHolbechArista changed the title Refactor(eos_cli_config_gen): Removing default type: switched from ethernet and port-channel interfaces Refactor(eos_cli_config_gen)!: Removing default type: switched from ethernet and port-channel interfaces Aug 13, 2024
@Shivani-gslab Shivani-gslab marked this pull request as draft August 13, 2024 07:27
@Shivani-gslab Shivani-gslab marked this pull request as ready for review August 13, 2024 07:41
@Shivani-gslab Shivani-gslab marked this pull request as draft August 13, 2024 09:21
@Shivani-gslab Shivani-gslab force-pushed the remove_default_type_switched branch 2 times, most recently from a3303ba to 2fc24d7 Compare August 13, 2024 10:24
@Shivani-gslab Shivani-gslab marked this pull request as ready for review August 13, 2024 10:28
Copy link

sonarcloud bot commented Aug 13, 2024

@ClausHolbechArista ClausHolbechArista added the one approval This PR has one approval and is only missing one more. label Aug 13, 2024
@ClausHolbechArista ClausHolbechArista merged commit 35547f4 into aristanetworks:devel Aug 13, 2024
59 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
one approval This PR has one approval and is only missing one more. rn: Refactor(eos_cli_config_gen)! state: CI Updated CI scenario have been updated in the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants