Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor(eos_cli_config_gen): Allow duplicate value of address in router_pim_sparse_mode.rp_addresses #4366

Conversation

laxmikantchintakindi
Copy link
Contributor

@laxmikantchintakindi laxmikantchintakindi commented Aug 16, 2024

Change Summary

Allow duplicate value of address in router_pim_sparse_mode.rp_addresses.

Related Issue(s)

Fixes #

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

Remove primary_key mark in router_pim_sparse_mode.rp_addresses

How to test

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

Copy link

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4366
# Activate the virtual environment
source test-avd-pr-4366/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/laxmikantchintakindi/avd.git@todo/router_pim_sparse_mode#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/laxmikantchintakindi/avd.git#/ansible_collections/arista/avd/,todo/router_pim_sparse_mode --force
# Optional: Install AVD examples
cd test-avd-pr-4366
ansible-playbook arista.avd.install_examples

@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role state: Documentation role Updated type: documentation Improvements or additions to documentation labels Aug 16, 2024
@github-actions github-actions bot removed the type: documentation Improvements or additions to documentation label Aug 16, 2024
@github-actions github-actions bot added the type: documentation Improvements or additions to documentation label Aug 19, 2024
@laxmikantchintakindi laxmikantchintakindi changed the title Cut(eos_cli_config_gen): Remove primary_key mark in router_pim_sparse_mode.rp_addresses Cut(eos_cli_config_gen): Allow duplicate value of address in router_pim_sparse_mode.rp_addresses Aug 19, 2024
@laxmikantchintakindi laxmikantchintakindi changed the title Cut(eos_cli_config_gen): Allow duplicate value of address in router_pim_sparse_mode.rp_addresses Refactor(eos_cli_config_gen): Allow duplicate value of address in router_pim_sparse_mode.rp_addresses Aug 19, 2024
Copy link
Contributor

@MaheshGSLAB MaheshGSLAB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add a test having same address two times

@github-actions github-actions bot added the state: CI Updated CI scenario have been updated in the PR label Aug 19, 2024
@github-actions github-actions bot removed the type: documentation Improvements or additions to documentation label Aug 20, 2024
@laxmikantchintakindi laxmikantchintakindi marked this pull request as ready for review August 20, 2024 12:58
@ClausHolbechArista ClausHolbechArista added the one approval This PR has one approval and is only missing one more. label Aug 21, 2024
@github-actions github-actions bot added the type: documentation Improvements or additions to documentation label Aug 22, 2024
@github-actions github-actions bot removed the type: documentation Improvements or additions to documentation label Aug 22, 2024
Copy link

sonarcloud bot commented Aug 23, 2024

@ClausHolbechArista ClausHolbechArista merged commit 402bb6d into aristanetworks:devel Aug 23, 2024
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
one approval This PR has one approval and is only missing one more. rn: Refactor(eos_cli_config_gen) role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants