Fix(eos_designs): Better error message when missing 'evpn_multicast' for PIM l3 interfaces #4391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…for PIM l3 interfaces
|
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4391
# Activate the virtual environment
source test-avd-pr-4391/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/gmuloc/avd.git@better-error-message-for-pim-gw#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/gmuloc/avd.git#/ansible_collections/arista/avd/,better-error-message-for-pim-gw --force
# Optional: Install AVD examples
cd test-avd-pr-4391
ansible-playbook arista.avd.install_examples |
github-actions
bot
added
the
state: CI Updated
python-avd/pyavd/_eos_designs/structured_config/network_services/ethernet_interfaces.py
Outdated
Show resolved
Hide resolved
...signs_negative_unit_tests/inventory/host_vars/failure-missing-evpn-multicast-l3-with-pim.yml
Outdated
Show resolved
Hide resolved
..._designs_negative_unit_tests/inventory/host_vars/failure-missing-evpn-multicast-with-pim.yml
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_designs/structured_config/network_services/ethernet_interfaces.py
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_designs/structured_config/network_services/ethernet_interfaces.py
Outdated
Show resolved
Hide resolved
ClausHolbechArista
added
the
cherry-pick-for-4.10.x
|
ClausHolbechArista
approved these changes
Aug 29, 2024
gmuloc
added
the
one approval
MaheshGSLAB
approved these changes
Aug 29, 2024
Vibhu-gslab
approved these changes
Aug 29, 2024
gmuloc
added a commit
to gmuloc/avd
that referenced
this pull request
Aug 29, 2024
…for PIM l3 interfaces (aristanetworks#4391)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
network_services l3_interfaces rely on
evpn_multicast_l3.enabledto be true at the VRF or tenant level to configure PIM. However ifevpn_multicastis not set totrueglobally, the filtered VRF object used to render the configuration will have the_evpn_multicast_l3_enabledkey unset which leads to a confusing error message for users having setevpn_multicast_l3.enabledto true as expected.Change Summary
Discriminate between the two error causes
Related Issue(s)
reported by the field on 4.10.0
Component(s) name
arista.avd.eos_designsProposed changes
Check for
evpn_multicastand output a different error message if falseHow to test
negative unit test added in molecule
Checklist
Repository Checklist