-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor(eos_designs): Move default platform_settings. network_services_keys and connected_endpoints_keys to schema #4395
Conversation
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4395
# Activate the virtual environment
source test-avd-pr-4395/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/gmuloc/avd.git@remove-duplicate-platform-default-values#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/gmuloc/avd.git#/ansible_collections/arista/avd/,remove-duplicate-platform-default-values --force
# Optional: Install AVD examples
cd test-avd-pr-4395
ansible-playbook arista.avd.install_examples |
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. As agreed we will remove the campus comment again.
This should help keep things in sync. We should look into the same for other defaults like network_services_keys and connected_endpoints_keys.
…ces_keys default to schema
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great stuff, tested with built-in examples. Configs generated correctly when specifying platforms and connected endpoints keys. LGTM
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Conflicts have been resolved. A maintainer will review the pull request shortly. |
Quality Gate passedIssues Measures |
Change Summary
Currently default platform_settingss are maintained both in schema default values and in the shared_utils python code.
This PR removes the python code.
It also leverages the same mechanism to retrieve the default value for
connected_endpoint_keys
andnetwork_services_keys
from the schemaComponent(s) name
arista.avd.eos_designs
Proposed changes
Read default values from schema
How to test
Molecule tests are still all passing without changes
Checklist
Repository Checklist