Refactor(eos_designs)!: Raise AVD error if sFlow is enabled but sflow_settings.destinations is not configured
#4402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4402
# Activate the virtual environment
source test-avd-pr-4402/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/MaheshGSLAB/ansible-avd.git@todo-sflow#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/MaheshGSLAB/ansible-avd.git#/ansible_collections/arista/avd/,todo-sflow --force
# Optional: Install AVD examples
cd test-avd-pr-4402
ansible-playbook arista.avd.install_examples |
github-actions
bot
added
the
state: CI Updated
MaheshGSLAB
changed the title
MaheshGSLAB
changed the title
MaheshGSLAB
changed the title
sflow_settings.destination is not configured
github-actions
bot
added
type: documentation
MaheshGSLAB
changed the title
sflow_settings.destination is not configuredsflow_settings.destinations is not configured
Vibhu-gslab
reviewed
Aug 28, 2024
python-avd/pyavd/_eos_designs/structured_config/flows/__init__.py
Outdated
Show resolved
Hide resolved
.../eos_designs_negative_unit_tests/inventory/host_vars/sflow-settings-missing-destinations.yml
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_designs/schema/schema_fragments/sflow_settings.schema.yml
Show resolved
Hide resolved
gmuloc
reviewed
Aug 29, 2024
Co-authored-by: Vibhu-gslab <109593615+Vibhu-gslab@users.noreply.github.com>
Vibhu-gslab
force-pushed
the
todo-sflow
branch
from
be7f936
to
8a2f54b
Compare
Co-authored-by: Guillaume Mulocher <gmulocher@arista.com>
Vibhu-gslab
approved these changes
Aug 29, 2024
laxmikantchintakindi
approved these changes
Aug 30, 2024
ClausHolbechArista
requested changes
Sep 2, 2024
Co-authored-by: Claus Holbech <holbech@arista.com>
|
ClausHolbechArista
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Raise an AVD error if sFlow is enabled but
sflow_settings.destinationsis not configured.Related Issue(s)
Fixes #
Component(s) name
arista.avd.eos_designsProposed changes
Added AVD error in case sFlow is enabled but
sflow_settings.destinationsis not configured.How to test
Run molecule
Checklist
User Checklist
Repository Checklist