Refactor(eos_designs)!: WAN default MTU set to 9194 for Dps and WAN HA interfaces and for LAN uplink interfaces added p2p_uplinks_mtu support in platform settings
#4415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4415
# Activate the virtual environment
source test-avd-pr-4415/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/MaheshGSLAB/ansible-avd.git@issue-4338#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/MaheshGSLAB/ansible-avd.git#/ansible_collections/arista/avd/,issue-4338 --force
# Optional: Install AVD examples
cd test-avd-pr-4415
ansible-playbook arista.avd.install_examples |
github-actions
bot
added
the
state: CI Updated
github-actions
bot
added
state: Documentation role Updated
role: eos_designs
MaheshGSLAB
changed the title
python-avd/pyavd/_eos_designs/schema/schema_fragments/p2p_uplinks_mtu.schema.yml
Outdated
Show resolved
Hide resolved
MaheshGSLAB
changed the title
github-actions
bot
added
the
type: documentation
MaheshGSLAB
changed the title
p2p_uplinks_mtu support in platform settings
python-avd/pyavd/_eos_designs/schema/schema_fragments/platform_settings.schema.yml
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_designs/schema/schema_fragments/p2p_uplinks_mtu.schema.yml
Outdated
Show resolved
Hide resolved
gmuloc
previously requested changes
Sep 3, 2024
...ions/arista/avd/molecule/eos_designs_unit_tests/inventory/group_vars/CV_PATHFINDER_TESTS.yml
Outdated
Show resolved
Hide resolved
...ions/arista/avd/molecule/eos_designs_unit_tests/inventory/group_vars/CV_PATHFINDER_TESTS.yml
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_designs/structured_config/underlay/ethernet_interfaces.py
Show resolved
Hide resolved
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
MaheshGSLAB
requested review from
ClausHolbechArista,
laxmikantchintakindi,
Shivani-gslab and
gmuloc
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
for more information, see https://pre-commit.ci
Vibhu-gslab
approved these changes
Sep 12, 2024
|
ClausHolbechArista
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
WAN default MTU set to 9194 for Dps and WAN HA interfaces and for LAN uplink interfaces added
p2p_uplinks_mtusupport in platform settings.The internal max IP MTU for CloudEOS is 9194 to give a max frame size of 9216 for DPDK.
Using higher MTU will lead to performance penalty because of fragmentation.
Related Issue(s)
Fixes #4338
Component(s) name
arista.avd.eos_designsProposed changes
WAN default MTU set to 9194 for Dps and WAN HA interfaces and for LAN uplink interfaces added
p2p_uplinks_mtusupport in platform settingsHow to test
Run molecule
Checklist
User Checklist
Repository Checklist