Refactor(eos_designs)!: Change the default mgmt_interface_description to upper case #4452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4452
# Activate the virtual environment
source test-avd-pr-4452/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/ClausHolbechArista/avd.git@refactor/eos_designs/mgmt-interface-description-upper-case#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/ClausHolbechArista/avd.git#/ansible_collections/arista/avd/,refactor/eos_designs/mgmt-interface-description-upper-case --force
# Optional: Install AVD examples
cd test-avd-pr-4452
ansible-playbook arista.avd.install_examples |
github-actions
bot
added
type: documentation
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Merged
4 tasks
ClausHolbechArista
force-pushed
the
refactor/eos_designs/mgmt-interface-description-upper-case
branch
from
c1b7a3b to
bc5e06a
Compare
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
MaheshGSLAB
approved these changes
Sep 13, 2024
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
ClausHolbechArista
force-pushed
the
refactor/eos_designs/mgmt-interface-description-upper-case
branch
from
f1b8f1d to
d2b05e7
Compare
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
ClausHolbechArista
force-pushed
the
refactor/eos_designs/mgmt-interface-description-upper-case
branch
from
d2b05e7 to
3ca7889
Compare
|
ClausHolbechArista
deleted the
refactor/eos_designs/mgmt-interface-description-upper-case
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Change the default mgmt_interface_description to upper case
Component(s) name
arista.avd.eos_designsProposed changes
mgmt_interface_descriptiontoOOB_MANAGEMENTHow to test
Already covered by molecule.
Checklist
User Checklist
Repository Checklist