-
Notifications
You must be signed in to change notification settings - Fork 235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor(eos_cli_config_gen): Rearrange the eos-cli config for vlan-interfaces
to match with EOS
#4488
Refactor(eos_cli_config_gen): Rearrange the eos-cli config for vlan-interfaces
to match with EOS
#4488
Conversation
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4488
# Activate the virtual environment
source test-avd-pr-4488/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/MaheshGSLAB/ansible-avd.git@vlan-config-order#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/MaheshGSLAB/ansible-avd.git#/ansible_collections/arista/avd/,vlan-config-order --force
# Optional: Install AVD examples
cd test-avd-pr-4488
ansible-playbook arista.avd.install_examples |
ansible_collections/arista/avd/molecule/eos_cli_config_gen/intended/configs/vlan-interfaces.cfg
Show resolved
Hide resolved
ansible_collections/arista/avd/molecule/eos_cli_config_gen/intended/configs/vlan-interfaces.cfg
Show resolved
Hide resolved
ansible_collections/arista/avd/molecule/eos_cli_config_gen/intended/configs/vlan-interfaces.cfg
Show resolved
Hide resolved
'ip helper-address...' commands is after 'ipv6 dhcp relay destinations' commands. |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Marking as draft until all comments have been addressed. Please resolve the comments when done. |
python-avd/pyavd/_eos_cli_config_gen/schema/schema_fragments/vlan_interfaces.schema.yml
Outdated
Show resolved
Hide resolved
d7fe305
to
ecea2e9
Compare
…lan_interfaces.schema.yml Co-authored-by: Shivani-gslab <145646625+Shivani-gslab@users.noreply.github.com>
Please retry analysis of this Pull-Request directly on SonarCloud |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Change Summary
Rearrange the eos-cli config for
vlan-interfaces
to match with EOS.Related Issue(s)
Fixes #
Component(s) name
arista.avd.eos_cli_config_gen
Proposed changes
Rearrange the eos-cli config for
vlan-interfaces
to match with EOS.How to test
Run molecule
Checklist
User Checklist
Repository Checklist