Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor(eos_cli_config_gen): Rearrange the eos-cli config for vlan-interfaces to match with EOS #4488

Merged

Conversation

MaheshGSLAB
Copy link
Contributor

Change Summary

Rearrange the eos-cli config for vlan-interfaces to match with EOS.

Related Issue(s)

Fixes #

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

Rearrange the eos-cli config for vlan-interfaces to match with EOS.

How to test

Run molecule

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@MaheshGSLAB MaheshGSLAB self-assigned this Sep 18, 2024
Copy link

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4488
# Activate the virtual environment
source test-avd-pr-4488/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/MaheshGSLAB/ansible-avd.git@vlan-config-order#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/MaheshGSLAB/ansible-avd.git#/ansible_collections/arista/avd/,vlan-config-order --force
# Optional: Install AVD examples
cd test-avd-pr-4488
ansible-playbook arista.avd.install_examples

@github-actions github-actions bot added the state: CI Updated CI scenario have been updated in the PR label Sep 18, 2024
@ClausHolbechArista ClausHolbechArista added this to the v5.0.0 milestone Sep 18, 2024
@MaheshGSLAB MaheshGSLAB marked this pull request as ready for review September 25, 2024 11:39
@MaheshGSLAB MaheshGSLAB requested review from a team as code owners September 25, 2024 11:39
@laxmikantchintakindi
Copy link
Contributor

laxmikantchintakindi commented Sep 27, 2024

'ip helper-address...' commands is after 'ipv6 dhcp relay destinations' commands.

@ClausHolbechArista ClausHolbechArista marked this pull request as draft September 30, 2024 10:31
@MaheshGSLAB

This comment was marked as resolved.

@laxmikantchintakindi

This comment was marked as resolved.

@laxmikantchintakindi

This comment was marked as resolved.

@MaheshGSLAB MaheshGSLAB marked this pull request as ready for review October 1, 2024 11:56
@ClausHolbechArista
Copy link
Contributor

Marking as draft until all comments have been addressed. Please resolve the comments when done.

@ClausHolbechArista ClausHolbechArista marked this pull request as draft October 2, 2024 08:27
Shivani-gslab

This comment was marked as resolved.

MaheshGSLAB and others added 2 commits October 7, 2024 09:36
…lan_interfaces.schema.yml

Co-authored-by: Shivani-gslab <145646625+Shivani-gslab@users.noreply.github.com>
@MaheshGSLAB MaheshGSLAB marked this pull request as ready for review October 7, 2024 04:06
Copy link

sonarqubecloud bot commented Oct 7, 2024

Please retry analysis of this Pull-Request directly on SonarCloud

Copy link
Contributor

@Shivani-gslab Shivani-gslab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ClausHolbechArista ClausHolbechArista merged commit b309e7a into aristanetworks:devel Oct 7, 2024
46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rn: Refactor(eos_cli_config_gen) state: CI Updated CI scenario have been updated in the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants