Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(eos_cli_config_gen): Do not render entries with only sequence number from ip_access_list #4492

Merged
merged 7 commits into from
Sep 23, 2024

Conversation

gmuloc
Copy link
Contributor

@gmuloc gmuloc commented Sep 18, 2024

Change Summary

Skip issues if remark or any field in [protocol, action, source, destination] is missing

Related Issue(s)

Fixes #4423

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

Test if the entry is empty, if it is skip rendering it (and the sequence number)

How to test

molecule - first commit demonstrate the issue, second solves it

Checklist

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@gmuloc gmuloc requested review from a team as code owners September 18, 2024 19:46
@gmuloc gmuloc added this to the v5.0.0 milestone Sep 18, 2024
Copy link

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4492
# Activate the virtual environment
source test-avd-pr-4492/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/gmuloc/avd.git@issue/4423#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/gmuloc/avd.git#/ansible_collections/arista/avd/,issue/4423 --force
# Optional: Install AVD examples
cd test-avd-pr-4492
ansible-playbook arista.avd.install_examples

@github-actions github-actions bot added the state: CI Updated CI scenario have been updated in the PR label Sep 18, 2024
Copy link
Contributor

@Vibhu-gslab Vibhu-gslab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

sonarcloud bot commented Sep 23, 2024

@ClausHolbechArista ClausHolbechArista merged commit af3ea14 into aristanetworks:devel Sep 23, 2024
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rn: Fix(eos_cli_config_gen) state: CI Updated CI scenario have been updated in the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix(eos_cli_config_gen): Do not render entries with only sequence number and nothing else from ip_access_list
3 participants