Refactor(eos_designs)!: Combine the VLAN trunk groups used for MLAG

[ClausHolbechArista]

Change Summary

Combine the VLAN trunk groups used for MLAG

Component(s) name

arista.avd.eos_designs

Proposed changes

Combine the VLAN trunk groups used for MLAG

With AVD version 5.0.0 a single MLAG trunk group is used for MLAG and MLAG L3 peerings, including the peerings in VRFs.
Previously MLAG L3 peerings used a separate LEAF_PEER_L3 trunk group.

The trunk group for MLAG L3 peerings can be reverted if needed:

+trunk_groups:
+  mlag_l3:
+    name: LEAF_PEER_L3

How to test

• Rerun molecule scenarios to see new default take effect
• Roll back change according to porting-guide suggestion in AVD_LAB for eos_designs_unit_tests and ensure no changes there.

Checklist

User Checklist

• N/A

Repository Checklist

• My code has been rebased from devel before I start
• I have read the CONTRIBUTING document.
• My change requires a change to the documentation and documentation have been updated accordingly.
• I have updated molecule CI testing accordingly. (check the box if not applicable)

[github-actions]

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4494
# Activate the virtual environment
source test-avd-pr-4494/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/ClausHolbechArista/avd.git@refactor/eos_designs/change-mlag-l3-trunk-group-name#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/ClausHolbechArista/avd.git#/ansible_collections/arista/avd/,refactor/eos_designs/change-mlag-l3-trunk-group-name --force
# Optional: Install AVD examples
cd test-avd-pr-4494
ansible-playbook arista.avd.install_examples

[github-actions]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[github-actions]

Conflicts have been resolved. A maintainer will review the pull request shortly.

[gmuloc]

LGTM - Should be merged after #4507 as it includes the same fixes (required to rerun molecule while resolving conflict)

[carlbuchmann]

LGTM

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud