Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(eos_designs): Add possibility to change network mask for direct WAN HA link #4497

Merged

Conversation

gmuloc
Copy link
Contributor

@gmuloc gmuloc commented Sep 19, 2024

Change Summary

cf title

Related Issue(s)

Reported from field

Component(s) name

arista.avd.eos_designs

Proposed changes

Add a setting to manipulate the default value for HA mask

How to test

molecule

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

Copy link

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4497
# Activate the virtual environment
source test-avd-pr-4497/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/gmuloc/avd.git@allow-different-mask-for-direct-wan-ha#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/gmuloc/avd.git#/ansible_collections/arista/avd/,allow-different-mask-for-direct-wan-ha --force
# Optional: Install AVD examples
cd test-avd-pr-4497
ansible-playbook arista.avd.install_examples

@github-actions github-actions bot added state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated role: eos_designs issue related to eos_designs role labels Sep 19, 2024
@gmuloc gmuloc marked this pull request as ready for review September 20, 2024 15:09
@gmuloc gmuloc requested review from a team as code owners September 20, 2024 15:09
python-avd/pyavd/api/ip_addressing/__init__.py Outdated Show resolved Hide resolved
python-avd/pyavd/api/ip_addressing/__init__.py Outdated Show resolved Hide resolved
python-avd/pyavd/api/ip_addressing/__init__.py Outdated Show resolved Hide resolved
python-avd/pyavd/api/ip_addressing/utils.py Outdated Show resolved Hide resolved
@gmuloc gmuloc requested review from ClausHolbechArista and a team September 24, 2024 12:32
@ClausHolbechArista ClausHolbechArista added the one approval This PR has one approval and is only missing one more. label Sep 25, 2024
@gmuloc gmuloc requested a review from a team September 25, 2024 09:09
Copy link

sonarcloud bot commented Sep 26, 2024

Copy link
Member

@carlbuchmann carlbuchmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, reviewed and tested with systest inventory.

@carlbuchmann carlbuchmann merged commit 598da55 into aristanetworks:devel Sep 26, 2024
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
EPIC - AVD AutoVPN/WAN one approval This PR has one approval and is only missing one more. rn: Feat(eos_designs) role: eos_designs issue related to eos_designs role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants