Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(eos_designs): Update eos_designs code to generate new interface-encapsulation model in structured_configs #4504

Merged
merged 7 commits into from
Sep 24, 2024

Conversation

Shivani-gslab
Copy link
Contributor

@Shivani-gslab Shivani-gslab commented Sep 20, 2024

Change Summary

Update eos_designs code to generate new interface encapsulation model in structured_configs

Related Issue(s)

Fixes #4498

Component(s) name

arista.avd.eos_designs

Proposed changes

Update eos_designs code to generate new interface encapsulation model in structured_configs

  • type: l3dot1q and type: l2dot1q will be removed from structured-configs.
  • encapsulation_dot1q_vlan and encapsulation_vlan model is updated in code.
  • Fixing some missed updates for switchport in port-channel-interfaces.

How to test

New models for encapsulation should be generated in structured-configs on running eos_designs role.

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

Copy link

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4504
# Activate the virtual environment
source test-avd-pr-4504/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/Shivani-gslab/avd.git@encapsulation_eos_designs#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/Shivani-gslab/avd.git#/ansible_collections/arista/avd/,encapsulation_eos_designs --force
# Optional: Install AVD examples
cd test-avd-pr-4504
ansible-playbook arista.avd.install_examples

@github-actions github-actions bot added the state: CI Updated CI scenario have been updated in the PR label Sep 20, 2024
@Shivani-gslab Shivani-gslab changed the title Update eos_designs code to generate new interface encapsulation model in structured_configs Feat(eos_designs): Update eos_designs code to generate new interface encapsulation model in structured_configs Sep 20, 2024
@ClausHolbechArista ClausHolbechArista added this to the v5.0.0 milestone Sep 23, 2024
@Shivani-gslab Shivani-gslab marked this pull request as ready for review September 23, 2024 09:06
@Shivani-gslab Shivani-gslab requested review from a team as code owners September 23, 2024 09:06
@Shivani-gslab Shivani-gslab changed the title Feat(eos_designs): Update eos_designs code to generate new interface encapsulation model in structured_configs Feat(eos_designs): Update eos_designs code to generate new interface-encapsulation model in structured_configs Sep 23, 2024
@Shivani-gslab Shivani-gslab marked this pull request as draft September 24, 2024 08:54
Copy link

sonarcloud bot commented Sep 24, 2024

@ClausHolbechArista ClausHolbechArista marked this pull request as ready for review September 24, 2024 13:07
@ClausHolbechArista ClausHolbechArista added the one approval This PR has one approval and is only missing one more. label Sep 24, 2024
@gmuloc gmuloc merged commit 2f9d141 into aristanetworks:devel Sep 24, 2024
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
one approval This PR has one approval and is only missing one more. rn: Feat(eos_designs) state: CI Updated CI scenario have been updated in the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update eos_designs code to generate new interface encapsulation model in structured_configs
3 participants