-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat(eos_designs): Update eos_designs code to generate new interface-encapsulation model in structured_configs #4504
Merged
gmuloc
merged 7 commits into
aristanetworks:devel
from
Shivani-gslab:encapsulation_eos_designs
Sep 24, 2024
Merged
Feat(eos_designs): Update eos_designs code to generate new interface-encapsulation model in structured_configs #4504
gmuloc
merged 7 commits into
aristanetworks:devel
from
Shivani-gslab:encapsulation_eos_designs
Sep 24, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4504
# Activate the virtual environment
source test-avd-pr-4504/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/Shivani-gslab/avd.git@encapsulation_eos_designs#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/Shivani-gslab/avd.git#/ansible_collections/arista/avd/,encapsulation_eos_designs --force
# Optional: Install AVD examples
cd test-avd-pr-4504
ansible-playbook arista.avd.install_examples |
github-actions
bot
added
the
state: CI Updated
CI scenario have been updated in the PR
label
Sep 20, 2024
Shivani-gslab
changed the title
Update eos_designs code to generate new interface encapsulation model in structured_configs
Feat(eos_designs): Update eos_designs code to generate new interface encapsulation model in structured_configs
Sep 20, 2024
Shivani-gslab
force-pushed
the
encapsulation_eos_designs
branch
from
September 23, 2024 05:31
f99496f
to
fee8184
Compare
Shivani-gslab
force-pushed
the
encapsulation_eos_designs
branch
from
September 23, 2024 07:33
7d7330b
to
56c9f7a
Compare
Shivani-gslab
force-pushed
the
encapsulation_eos_designs
branch
from
September 23, 2024 09:06
d68c6ed
to
fcfe3de
Compare
Shivani-gslab
changed the title
Feat(eos_designs): Update eos_designs code to generate new interface encapsulation model in structured_configs
Feat(eos_designs): Update eos_designs code to generate new interface-encapsulation model in structured_configs
Sep 23, 2024
Quality Gate passedIssues Measures |
ClausHolbechArista
approved these changes
Sep 24, 2024
ClausHolbechArista
added
the
one approval
This PR has one approval and is only missing one more.
label
Sep 24, 2024
gmuloc
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
one approval
This PR has one approval and is only missing one more.
rn: Feat(eos_designs)
state: CI Updated
CI scenario have been updated in the PR
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Update eos_designs code to generate new interface encapsulation model in structured_configs
Related Issue(s)
Fixes #4498
Component(s) name
arista.avd.eos_designs
Proposed changes
Update eos_designs code to generate new interface encapsulation model in structured_configs
type: l3dot1q
andtype: l2dot1q
will be removed from structured-configs.encapsulation_dot1q_vlan
andencapsulation_vlan
model is updated in code.How to test
New models for
encapsulation
should be generated in structured-configs on running eos_designs role.Checklist
User Checklist
Repository Checklist