Refactor(eos_designs)!: Change L3 P2P descriptions for uplinks and p2p_links

[ClausHolbechArista]

Change Summary

Change L3 P2P descriptions for uplinks and p2p_links

Component(s) name

arista.avd.eos_designs

Proposed changes

• Adding new default descriptions for MLAG SVIs and VLANs
• Add templating support for all
• Add keys with default templates:
  • default_underlay_p2p_ethernet_description
  • default_underlay_p2p_port_channel_description
• Updated porting guide

How to test

• Update molecule scenarios and examples
• Verified no changes for scenarios with custom description logic in unit tests

Checklist

User Checklist

• N/A

Repository Checklist

• My code has been rebased from devel before I start
• I have read the CONTRIBUTING document.
• My change requires a change to the documentation and documentation have been updated accordingly.
• I have updated molecule CI testing accordingly. (check the box if not applicable)

[github-actions]

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4520
# Activate the virtual environment
source test-avd-pr-4520/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/ClausHolbechArista/avd.git@refactor/eos_designs/l3-p2p-descriptions#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/ClausHolbechArista/avd.git#/ansible_collections/arista/avd/,refactor/eos_designs/l3-p2p-descriptions --force
# Optional: Install AVD examples
cd test-avd-pr-4520
ansible-playbook arista.avd.install_examples

[github-actions]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[github-actions]

Conflicts have been resolved. A maintainer will review the pull request shortly.

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[carlbuchmann]

LGTM - tested in local inventory and reverting to 4.x values.

[marcusmcpeek]

LGTM - I tested changing the p2p description to something custom and also a dci interface to something custom. I also verified reverting to previous descriptions worked by following the porting guide. I did not have port-channels for uplinks in my repository, so I did not test that.