Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(eos_designs): Make it possible to add custom PTP profiles #4523

Merged

Conversation

gmuloc
Copy link
Contributor

@gmuloc gmuloc commented Sep 27, 2024

Change Summary

Follow up to #4516

Tackling raising when invalid PTP profiles are referred - this required a couple of changes defined below

Related Issue(s)

Follow up to #3930

Component(s) name

arista.avd.eos_designs

Proposed changes

  • Remove valid_values for ptp_profiles in various places
  • Read default ptp_profiles from schema directly rather than from python file
  • raise when an invalid ptp_profile is used in adapters / network_ports / node
  • Implement a test where a custom PTP profile is used
  • Update release notes

How to test

molecule

Checklist

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

Copy link

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4523
# Activate the virtual environment
source test-avd-pr-4523/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/gmuloc/avd.git@allow-custom-ptp-profiles#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/gmuloc/avd.git#/ansible_collections/arista/avd/,allow-custom-ptp-profiles --force
# Optional: Install AVD examples
cd test-avd-pr-4523
ansible-playbook arista.avd.install_examples

@github-actions github-actions bot added state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated role: eos_designs issue related to eos_designs role labels Sep 27, 2024
@gmuloc gmuloc added this to the v5.0.0 milestone Sep 27, 2024
@github-actions github-actions bot added the state: conflict PR with conflict label Sep 27, 2024
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the state: conflict PR with conflict label Sep 27, 2024
Copy link

Conflicts have been resolved. A maintainer will review the pull request shortly.

@gmuloc gmuloc changed the title Refactor(eos_designs): Make it possible to add custom PTP profiles Fix(eos_designs): Make it possible to add custom PTP profiles Sep 30, 2024
@github-actions github-actions bot added type: documentation Improvements or additions to documentation state: conflict PR with conflict labels Sep 30, 2024
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@gmuloc gmuloc marked this pull request as ready for review September 30, 2024 14:01
@gmuloc gmuloc requested review from a team as code owners September 30, 2024 14:01
@github-actions github-actions bot removed the state: conflict PR with conflict label Sep 30, 2024
Copy link

Conflicts have been resolved. A maintainer will review the pull request shortly.

Copy link
Member

@carlbuchmann carlbuchmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@carlbuchmann carlbuchmann requested a review from a team September 30, 2024 14:25
@carlbuchmann carlbuchmann self-requested a review October 2, 2024 15:36
Copy link

sonarcloud bot commented Oct 3, 2024

@ClausHolbechArista ClausHolbechArista merged commit 863f2c9 into aristanetworks:devel Oct 3, 2024
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rn: Fix(eos_designs) role: eos_designs issue related to eos_designs role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated type: documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants