-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix(eos_designs): Make it possible to add custom PTP profiles #4523
Fix(eos_designs): Make it possible to add custom PTP profiles #4523
Conversation
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4523
# Activate the virtual environment
source test-avd-pr-4523/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/gmuloc/avd.git@allow-custom-ptp-profiles#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/gmuloc/avd.git#/ansible_collections/arista/avd/,allow-custom-ptp-profiles --force
# Optional: Install AVD examples
cd test-avd-pr-4523
ansible-playbook arista.avd.install_examples |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Conflicts have been resolved. A maintainer will review the pull request shortly. |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Conflicts have been resolved. A maintainer will review the pull request shortly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
..._negative_unit_tests/inventory/host_vars/failure-network-port-ptp-profile-does-not-exist.yml
Outdated
Show resolved
Hide resolved
Quality Gate passedIssues Measures |
Change Summary
Follow up to #4516
Tackling raising when invalid PTP profiles are referred - this required a couple of changes defined below
Related Issue(s)
Follow up to #3930
Component(s) name
arista.avd.eos_designs
Proposed changes
How to test
molecule
Checklist
Repository Checklist