Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(eos_designs): Configure l3 interfaces BGP peers even when underlay_bgp is False #4543

Merged
merged 21 commits into from
Oct 10, 2024

Conversation

gmuloc
Copy link
Contributor

@gmuloc gmuloc commented Oct 2, 2024

Change Summary

cf title

Related Issue(s)

Fixes #4542

Component(s) name

arista.avd.eos_designs

Proposed changes

in structured_config/underlay/router_bgp.py always render any BGP peer configured under node l3_interfaces.

How to test

molecule scenario added

Checklist

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

Copy link

github-actions bot commented Oct 2, 2024

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4543
# Activate the virtual environment
source test-avd-pr-4543/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/gmuloc/avd.git@issue/4252#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/gmuloc/avd.git#/ansible_collections/arista/avd/,issue/4252 --force
# Optional: Install AVD examples
cd test-avd-pr-4543
ansible-playbook arista.avd.install_examples

@github-actions github-actions bot added the state: CI Updated CI scenario have been updated in the PR label Oct 2, 2024
@gmuloc gmuloc added this to the v5.0.0 milestone Oct 2, 2024
@carlbuchmann carlbuchmann marked this pull request as draft October 7, 2024 13:53
@gmuloc gmuloc marked this pull request as ready for review October 7, 2024 15:11
@gmuloc gmuloc requested review from ClausHolbechArista and a team October 7, 2024 15:11
…/inventory/host_vars/node-type-l3-interfaces-bgp.yml
@github-actions github-actions bot added type: documentation Improvements or additions to documentation state: Documentation role Updated role: eos_designs issue related to eos_designs role labels Oct 9, 2024
Copy link
Contributor Author

@gmuloc gmuloc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

sonarcloud bot commented Oct 10, 2024

@ClausHolbechArista ClausHolbechArista merged commit ec81f6c into aristanetworks:devel Oct 10, 2024
40 checks passed
@gmuloc gmuloc mentioned this pull request Oct 10, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
EPIC - AVD AutoVPN/WAN rn: Feat(eos_designs) role: eos_designs issue related to eos_designs role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated type: documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix(eos_designs): bgp peer on l3 interface not working when uplink_type: lan
2 participants