-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor(eos_cli_config_gen): Rearrange the eos-cli config for ethernet-interfaces to match with EOS #4569
Refactor(eos_cli_config_gen): Rearrange the eos-cli config for ethernet-interfaces to match with EOS #4569
Conversation
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4569
# Activate the virtual environment
source test-avd-pr-4569/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/Vibhu-gslab/avd.git@eth_int_reordering#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/Vibhu-gslab/avd.git#/ansible_collections/arista/avd/,eth_int_reordering --force
# Optional: Install AVD examples
cd test-avd-pr-4569
ansible-playbook arista.avd.install_examples |
c46211e
to
1480978
Compare
python-avd/pyavd/_eos_cli_config_gen/j2templates/eos/ethernet-interfaces.j2
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_cli_config_gen/j2templates/eos/ethernet-interfaces.j2
Show resolved
Hide resolved
python-avd/pyavd/_eos_cli_config_gen/j2templates/eos/ethernet-interfaces.j2
Show resolved
Hide resolved
python-avd/pyavd/_eos_cli_config_gen/j2templates/eos/ethernet-interfaces.j2
Show resolved
Hide resolved
python-avd/pyavd/_eos_cli_config_gen/j2templates/eos/ethernet-interfaces.j2
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_cli_config_gen/j2templates/eos/ethernet-interfaces.j2
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_cli_config_gen/j2templates/eos/ethernet-interfaces.j2
Show resolved
Hide resolved
python-avd/pyavd/_eos_cli_config_gen/j2templates/eos/ethernet-interfaces.j2
Outdated
Show resolved
Hide resolved
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Conflicts have been resolved. A maintainer will review the pull request shortly. |
83ab9d0
to
9b994fa
Compare
python-avd/pyavd/_eos_cli_config_gen/j2templates/eos/ethernet-interfaces.j2
Outdated
Show resolved
Hide resolved
9b994fa
to
815298f
Compare
python-avd/pyavd/_eos_cli_config_gen/j2templates/eos/ethernet-interfaces.j2
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_cli_config_gen/j2templates/eos/ethernet-interfaces.j2
Show resolved
Hide resolved
…et-interfaces to match with EOS
33d199b
to
86bbc8f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…et-interfaces to match with EOS (aristanetworks#4569)
Change Summary
Rearrange the eos-cli config for ethernet-interfaces to match with EOS
Related Issue(s)
Fixes #
Component(s) name
arista.avd.eos_cli_config_gen
Checklist
Repository Checklist