Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor(eos_cli_config_gen): Rearrange the eos-cli config for ethernet-interfaces to match with EOS #4569

Merged

Conversation

Vibhu-gslab
Copy link
Contributor

Change Summary

Rearrange the eos-cli config for ethernet-interfaces to match with EOS

Related Issue(s)

Fixes #

Component(s) name

arista.avd.eos_cli_config_gen

Checklist

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@Vibhu-gslab Vibhu-gslab added this to the v5.0.0 milestone Oct 9, 2024
@Vibhu-gslab Vibhu-gslab self-assigned this Oct 9, 2024
Copy link

github-actions bot commented Oct 9, 2024

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4569
# Activate the virtual environment
source test-avd-pr-4569/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/Vibhu-gslab/avd.git@eth_int_reordering#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/Vibhu-gslab/avd.git#/ansible_collections/arista/avd/,eth_int_reordering --force
# Optional: Install AVD examples
cd test-avd-pr-4569
ansible-playbook arista.avd.install_examples

@github-actions github-actions bot added the state: CI Updated CI scenario have been updated in the PR label Oct 9, 2024
@github-actions github-actions bot added the state: conflict PR with conflict label Oct 10, 2024
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Copy link

Conflicts have been resolved. A maintainer will review the pull request shortly.

@github-actions github-actions bot removed the state: conflict PR with conflict label Oct 10, 2024
@Vibhu-gslab Vibhu-gslab force-pushed the eth_int_reordering branch 2 times, most recently from 83ab9d0 to 9b994fa Compare October 10, 2024 12:08
@MaheshGSLAB MaheshGSLAB marked this pull request as ready for review October 10, 2024 13:22
@MaheshGSLAB MaheshGSLAB requested review from a team as code owners October 10, 2024 13:22
Copy link
Contributor

@Shivani-gslab Shivani-gslab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role state: Documentation role Updated labels Oct 11, 2024
Copy link

sonarcloud bot commented Oct 11, 2024

Copy link
Contributor

@ClausHolbechArista ClausHolbechArista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ClausHolbechArista ClausHolbechArista merged commit bc34a05 into aristanetworks:devel Oct 11, 2024
43 checks passed
nathanmusser pushed a commit to nathanmusser/avd that referenced this pull request Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rn: Refactor(eos_cli_config_gen) role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants