Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor(eos_cli_config_gen): Rearrange the CLI for platform #4578

Conversation

ClausHolbechArista
Copy link
Contributor

Change Summary

Rearrange the CLI for platform

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

Moving generated CLI lines around according to EOS order.

How to test

Tested manually on a trident and a sand device with FastCli -G

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

Copy link

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4578
# Activate the virtual environment
source test-avd-pr-4578/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/ClausHolbechArista/avd.git@refactor/eos_cliconfig_gen/reorder-platform#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/ClausHolbechArista/avd.git#/ansible_collections/arista/avd/,refactor/eos_cliconfig_gen/reorder-platform --force
# Optional: Install AVD examples
cd test-avd-pr-4578
ansible-playbook arista.avd.install_examples

@github-actions github-actions bot added the state: CI Updated CI scenario have been updated in the PR label Oct 10, 2024
Copy link

sonarcloud bot commented Oct 10, 2024

@ClausHolbechArista ClausHolbechArista added this to the v5.0.0 milestone Oct 10, 2024
@gmuloc gmuloc added the one approval This PR has one approval and is only missing one more. label Oct 10, 2024
@gmuloc gmuloc requested a review from a team October 10, 2024 13:37
Copy link
Member

@carlbuchmann carlbuchmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@carlbuchmann carlbuchmann merged commit 3bf67f2 into aristanetworks:devel Oct 10, 2024
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
one approval This PR has one approval and is only missing one more. rn: Refactor(eos_cli_config_gen) state: CI Updated CI scenario have been updated in the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants