-
Notifications
You must be signed in to change notification settings - Fork 235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cut: Remove deprecated deploy_to_cv role #4609
Cut: Remove deprecated deploy_to_cv role #4609
Conversation
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4609
# Activate the virtual environment
source test-avd-pr-4609/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/gmuloc/avd.git@chore-clean-removed-role#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/gmuloc/avd.git#/ansible_collections/arista/avd/,chore-clean-removed-role --force
# Optional: Install AVD examples
cd test-avd-pr-4609
ansible-playbook arista.avd.install_examples |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Also confirmed with molecule's cv_deploy
scenario
|
Change Summary
Role was deprecated in 4.x and planned for removal in 5.x
Component(s) name
arista.avd.deploy_to_cv
Proposed changes
Removing the role (there is no process for this in Ansible, only for plugins)
Checklist
Repository Checklist