Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cut: Remove deprecated deploy_to_cv role #4609

Merged

Conversation

gmuloc
Copy link
Contributor

@gmuloc gmuloc commented Oct 17, 2024

Change Summary

Role was deprecated in 4.x and planned for removal in 5.x

Component(s) name

arista.avd.deploy_to_cv

Proposed changes

Removing the role (there is no process for this in Ansible, only for plugins)

Checklist

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@gmuloc gmuloc requested review from a team as code owners October 17, 2024 12:13
@gmuloc gmuloc added this to the v5.0.0 milestone Oct 17, 2024
Copy link

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4609
# Activate the virtual environment
source test-avd-pr-4609/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/gmuloc/avd.git@chore-clean-removed-role#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/gmuloc/avd.git#/ansible_collections/arista/avd/,chore-clean-removed-role --force
# Optional: Install AVD examples
cd test-avd-pr-4609
ansible-playbook arista.avd.install_examples

@github-actions github-actions bot added type: documentation Improvements or additions to documentation state: Documentation role Updated labels Oct 17, 2024
Copy link
Member

@carlbuchmann carlbuchmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gmuloc gmuloc added the one approval This PR has one approval and is only missing one more. label Oct 17, 2024
Copy link
Contributor

@alexeygorbunov alexeygorbunov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Also confirmed with molecule's cv_deploy scenario

Copy link

@ClausHolbechArista ClausHolbechArista merged commit 4e74b9a into aristanetworks:devel Oct 18, 2024
42 checks passed
gmuloc added a commit to gmuloc/avd that referenced this pull request Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
one approval This PR has one approval and is only missing one more. rn: Cut state: Documentation role Updated type: documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants