-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat(eos_designs): Add support to use router general for router id #4687
Merged
gmuloc
merged 14 commits into
aristanetworks:devel
from
laxmikantchintakindi:feat/eos_designs/router-general-router-id
Nov 12, 2024
Merged
Feat(eos_designs): Add support to use router general for router id #4687
gmuloc
merged 14 commits into
aristanetworks:devel
from
laxmikantchintakindi:feat/eos_designs/router-general-router-id
Nov 12, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4687
# Activate the virtual environment
source test-avd-pr-4687/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/laxmikantchintakindi/avd.git@feat/eos_designs/router-general-router-id#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/laxmikantchintakindi/avd.git#/ansible_collections/arista/avd/,feat/eos_designs/router-general-router-id --force
# Optional: Install AVD examples
cd test-avd-pr-4687
ansible-playbook arista.avd.install_examples |
github-actions
bot
added
state: CI Updated
CI scenario have been updated in the PR
state: Documentation role Updated
role: eos_designs
issue related to eos_designs role
labels
Nov 6, 2024
laxmikantchintakindi
force-pushed
the
feat/eos_designs/router-general-router-id
branch
3 times, most recently
from
November 6, 2024 05:54
a60d675
to
a2da7e8
Compare
ClausHolbechArista
requested changes
Nov 6, 2024
python-avd/pyavd/_eos_designs/schema/schema_fragments/router_general.schema.yml
Outdated
Show resolved
Hide resolved
...n-avd/pyavd/_eos_designs/schema/schema_fragments/use_router_general_for_router_id.schema.yml
Outdated
Show resolved
Hide resolved
laxmikantchintakindi
force-pushed
the
feat/eos_designs/router-general-router-id
branch
7 times, most recently
from
November 11, 2024 09:00
0c43724
to
66e4de9
Compare
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
laxmikantchintakindi
force-pushed
the
feat/eos_designs/router-general-router-id
branch
from
November 11, 2024 09:03
66e4de9
to
1bdab3b
Compare
ClausHolbechArista
requested changes
Nov 11, 2024
...ctions/arista/avd/molecule/eos_designs_unit_tests/intended/structured_configs/DC1-SPINE4.yml
Outdated
Show resolved
Hide resolved
..._collections/arista/avd/molecule/eos_designs_unit_tests/intended/configs/core-2-ospf-ldp.cfg
Show resolved
Hide resolved
python-avd/pyavd/_eos_designs/structured_config/network_services/router_ospf.py
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_designs/structured_config/underlay/router_ospf.py
Outdated
Show resolved
Hide resolved
ClausHolbechArista
requested changes
Nov 11, 2024
python-avd/pyavd/_eos_designs/structured_config/base/__init__.py
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_designs/structured_config/network_services/router_ospf.py
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_designs/structured_config/network_services/router_ospf.py
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_designs/structured_config/underlay/router_ospf.py
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_designs/structured_config/underlay/router_isis.py
Outdated
Show resolved
Hide resolved
laxmikantchintakindi
force-pushed
the
feat/eos_designs/router-general-router-id
branch
from
November 11, 2024 14:53
7b3a35a
to
82e8faa
Compare
laxmikantchintakindi
force-pushed
the
feat/eos_designs/router-general-router-id
branch
from
November 11, 2024 14:59
82e8faa
to
9a10987
Compare
laxmikantchintakindi
force-pushed
the
feat/eos_designs/router-general-router-id
branch
from
November 11, 2024 15:04
9a10987
to
23dbfae
Compare
Co-authored-by: Claus Holbech <holbech@arista.com>
laxmikantchintakindi
force-pushed
the
feat/eos_designs/router-general-router-id
branch
from
November 11, 2024 15:17
1b7589c
to
d86885b
Compare
ClausHolbechArista
approved these changes
Nov 11, 2024
ClausHolbechArista
added
the
one approval
This PR has one approval and is only missing one more.
label
Nov 11, 2024
Quality Gate passedIssues Measures |
gmuloc
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
one approval
This PR has one approval and is only missing one more.
rn: Feat(eos_designs)
role: eos_designs
issue related to eos_designs role
state: CI Updated
CI scenario have been updated in the PR
state: Documentation role Updated
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Add support to use router general for router id.
Related Issue(s)
Fixes #1245
Component(s) name
arista.avd.eos_designs
Proposed changes
Starting EOS 4.22.1F (https://eos.arista.com/eos-4-22-1f/general-router-id/) we support to set global router-id which can inherited to all BGP VRFs. Currently, AVD add router-id knob per VRF, which is suboptimal comparing to single global router-id config.
How to test
Checklist
User Checklist
Repository Checklist