Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor(eos_cli_config_gen): Adding check for hosts key in TACACS server j2 file #4701

Merged
merged 2 commits into from
Nov 11, 2024

Conversation

Vibhu-gslab
Copy link
Contributor

@Vibhu-gslab Vibhu-gslab commented Nov 8, 2024

Change Summary

Adding check for hosts key in TACACS server j2 file

Related Issue(s)

Fixes #4649

Component(s) name

arista.avd.eos_cli_config_gen

Checklist

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

Copy link

github-actions bot commented Nov 8, 2024

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4701
# Activate the virtual environment
source test-avd-pr-4701/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/Vibhu-gslab/avd.git@TACACS#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/Vibhu-gslab/avd.git#/ansible_collections/arista/avd/,TACACS --force
# Optional: Install AVD examples
cd test-avd-pr-4701
ansible-playbook arista.avd.install_examples

@Vibhu-gslab Vibhu-gslab marked this pull request as ready for review November 11, 2024 07:16
@Vibhu-gslab Vibhu-gslab requested review from a team as code owners November 11, 2024 07:16
@ClausHolbechArista ClausHolbechArista added the one approval This PR has one approval and is only missing one more. label Nov 11, 2024
@ClausHolbechArista ClausHolbechArista requested a review from a team November 11, 2024 08:07
Copy link

sonarcloud bot commented Nov 11, 2024

Copy link
Contributor

@Shivani-gslab Shivani-gslab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ClausHolbechArista ClausHolbechArista merged commit 2698a0d into aristanetworks:devel Nov 11, 2024
45 checks passed
Vibhu-gslab added a commit to Vibhu-gslab/avd that referenced this pull request Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
one approval This PR has one approval and is only missing one more. rn: Refactor(eos_cli_config_gen)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TACACS server config error out for hosts key not defined
3 participants