Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Global ARP timer option #479

Merged
merged 6 commits into from
Dec 21, 2020
Merged

Global ARP timer option #479

merged 6 commits into from
Dec 21, 2020

Conversation

onurgashi
Copy link
Contributor

Change Summary

Knob to change ARP timer globally.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Documentation content changes
  • Other (please describe):

Related Issue(s)

Fixes #477

Component(s) name

eos_cli_config_gen

Proposed changes

Added knob
Added doc
Tested in DUT and molecule (wrong title for doc, fixed it in later commit.)

How to test

Molecule

Checklist:

  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed (pre-commit, make linting and make sanity-lint).
  • I have updated molecule CI testing accordingly

@onurgashi onurgashi added type: documentation Improvements or additions to documentation role: eos_cli_config_gen issue related to eos_cli_config_gen role labels Dec 11, 2020
@github-actions github-actions bot added state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated labels Dec 11, 2020
@onurgashi onurgashi marked this pull request as ready for review December 11, 2020 20:27
titom73
titom73 approved these changes Dec 15, 2020
View reviewed changes
Copy link
Contributor

@titom73 titom73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Just need to confirm with @aphillipps if the data model is OK

@titom73 titom73 added this to the v1.1.3 milestone Dec 15, 2020
ClausHolbechArista
ClausHolbechArista requested changes Dec 15, 2020
View reviewed changes
Copy link
Contributor

@ClausHolbechArista ClausHolbechArista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing newlines at the end of the new templates

@carlbuchmann carlbuchmann modified the milestones: v1.1.3, v1.2.0 Dec 16, 2020
@onurgashi
Copy link
Contributor Author

Resolved the discrepancies.

ClausHolbechArista
ClausHolbechArista approved these changes Dec 19, 2020
View reviewed changes
Copy link
Contributor

@ClausHolbechArista ClausHolbechArista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

titom73
titom73 approved these changes Dec 21, 2020
View reviewed changes
Copy link
Contributor

@titom73 titom73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@titom73 titom73 merged commit b0be8ab into aristanetworks:devel Dec 21, 2020
@sugetha24 sugetha24 mentioned this pull request Jul 18, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ClausHolbechArista ClausHolbechArista ClausHolbechArista approved these changes

@titom73 titom73 titom73 approved these changes

@aphillipps aphillipps Awaiting requested review from aphillipps

@carlbuchmann carlbuchmann Awaiting requested review from carlbuchmann

Assignees

@onurgashi onurgashi

Labels
role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated type: documentation Improvements or additions to documentation
Projects
None yet
Milestone
v2.0.0rc1
Development

Successfully merging this pull request may close these issues.

Global ARP ageing knob
4 participants
@onurgashi @titom73 @ClausHolbechArista @carlbuchmann