-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PTP capability #481
PTP capability #481
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small formatting changes required for readability, but functionality looks good.
Would be good to add more ptp interface knobs at some point (could just submit issue)
ansible_collections/arista/avd/roles/eos_cli_config_gen/templates/eos/ptp.j2
Show resolved
Hide resolved
ansible_collections/arista/avd/roles/eos_cli_config_gen/templates/documentation/ptp.j2
Outdated
Show resolved
Hide resolved
ansible_collections/arista/avd/roles/eos_cli_config_gen/templates/documentation/ptp.j2
Show resolved
Hide resolved
ansible_collections/arista/avd/roles/eos_cli_config_gen/templates/eos/ptp.j2
Show resolved
Hide resolved
Fixed em. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - tested with avd-validation lab.
This is great news. Looks like Christmas has come early!
|
Change Summary
Allows implementation of PTP in the eos_cli_config_gen
Next step add more knobs and maybe create data model for boradcast & media.
Types of changes
Related Issue(s)
Fixes #440
Component(s) name
eos_cli_config_gen
Proposed changes
Interface level and global ptp.j2
How to test
Successful venv/physical DUT, and molecule tests.
Checklist:
pre-commit
,make linting
andmake sanity-lint
).