Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PTP capability #481

Merged
merged 7 commits into from
Dec 22, 2020
Merged

PTP capability #481

merged 7 commits into from
Dec 22, 2020

Conversation

onurgashi
Copy link
Contributor

@onurgashi onurgashi commented Dec 11, 2020

Change Summary

Allows implementation of PTP in the eos_cli_config_gen

Next step add more knobs and maybe create data model for boradcast & media.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Documentation content changes
  • Other (please describe):

Related Issue(s)

Fixes #440

Component(s) name

eos_cli_config_gen

Proposed changes

Interface level and global ptp.j2

How to test

Successful venv/physical DUT, and molecule tests.

Checklist:

  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed (pre-commit, make linting and make sanity-lint).
  • I have updated molecule CI testing accordingly

@onurgashi onurgashi added type: documentation Improvements or additions to documentation type: enhancement New feature or request role: eos_cli_config_gen issue related to eos_cli_config_gen role labels Dec 11, 2020
@github-actions github-actions bot added state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated labels Dec 11, 2020
Copy link
Contributor

@ClausHolbechArista ClausHolbechArista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small formatting changes required for readability, but functionality looks good.
Would be good to add more ptp interface knobs at some point (could just submit issue)

@onurgashi
Copy link
Contributor Author

Fixed em.

Copy link
Contributor

@ClausHolbechArista ClausHolbechArista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@carlbuchmann carlbuchmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - tested with avd-validation lab.

@carlbuchmann carlbuchmann merged commit 8e032e5 into aristanetworks:devel Dec 22, 2020
@sundayN
Copy link

sundayN commented Dec 24, 2020

This is great news. Looks like Christmas has come early!
Now we just need to add some more options to ethernet_interfaces

ptp:
  announce:
    interval: < integer>
  sync-message:
    interval: <-integer>
  delay-req: <-integer>
  role: < master | slave >

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated type: documentation Improvements or additions to documentation type: enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for PTP capabilities
5 participants