Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the condition for interfaces description configuration #484

Merged
merged 1 commit into from
Dec 15, 2020
Merged

Fixed the condition for interfaces description configuration #484

merged 1 commit into from
Dec 15, 2020

Conversation

ksator
Copy link
Contributor

@ksator ksator commented Dec 13, 2020

Change Summary

Update the condition for interface description configuration

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Documentation content changes
  • Other (please describe):

Related Issue(s)

#483

Component(s) name

eos_cli_config_gen role
/eos/port-channel-interfaces.j2 template

Proposed changes

previous code:

interface {{ port_channel_interface }}
{%         if port_channel_interfaces[port_channel_interface].description is defined and port_channel_interfaces[port_channel_interface].shutdown is not none %}
   description {{ port_channel_interfaces[port_channel_interface].description }}
{%         endif %}

proposed change:

interface {{ port_channel_interface }}
{%         if port_channel_interfaces[port_channel_interface].description is defined and port_channel_interfaces[port_channel_interface].description is not none %}
   description {{ port_channel_interfaces[port_channel_interface].description }}
{%         endif %}

How to test

excecute the eos_cli_config_gen role

Checklist:

  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed (pre-commit, make linting and make sanity-lint).
  • I have updated molecule CI testing accordingly

@ksator ksator added the role: eos_cli_config_gen issue related to eos_cli_config_gen role label Dec 13, 2020
@ksator ksator self-assigned this Dec 13, 2020
@ksator ksator linked an issue Dec 14, 2020 that may be closed by this pull request
Copy link
Contributor

@aphillipps aphillipps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aphillipps aphillipps merged commit 1ae878f into aristanetworks:devel Dec 15, 2020
@ksator ksator deleted the issue/483 branch December 16, 2020 06:40
@titom73 titom73 added this to the v2.0.0rc1 milestone Jan 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
role: eos_cli_config_gen issue related to eos_cli_config_gen role
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update the condition for interfaces description configuration
3 participants