Router OSPF documentation #496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
role: eos_cli_config_gen
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
github-actions
bot
added
state: conflict
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
titom73
reviewed
Dec 22, 2020
| @@ -242,6 +242,9 @@ | |||
|
|
|||
| {% include 'documentation/ipv6-static-routes.j2' %} | |||
|
|
|||
| ## Router OSPF | |||
|
|
|||
| {% include 'documentation/router-ospf.j2' %} | |||
There was a problem hiding this comment.
We should include OSPF section in Table of content as well.
titom73
reviewed
Dec 22, 2020
| {% if loopback_interface_ospf.configured %} | ||
| {% for loopback_interface in loopback_interfaces | arista.avd.natural_sort %} | ||
| {% if loopback_interfaces[loopback_interface].ospf_area is defined and loopback_interfaces[loopback_interface].ospf_area is not none %} | ||
| | {{ loopback_interface }} | {{ loopback_interfaces[loopback_interface].ospf_area }} | {% if loopback_interfaces[loopback_interface].ospf_cost is defined and loopback_interfaces[loopback_interface].ospf_cost is not none %} {{ loopback_interfaces[loopback_interface].ospf_cost }} {% else %} - {% endif %} | {% if loopback_interfaces[loopback_interface].ospf_network_point_to_point is defined and loopback_interfaces[loopback_interface].ospf_network_point_to_point is not none %} {{ loopback_interfaces[loopback_interface].ospf_network_point_to_point }} {% else %} - {% endif %} | |
There was a problem hiding this comment.
Maybe we should add passive support for interface type like point-to-point
Need to agree if interfaces should be also in router ospf and if so, which format. This reverts commit 6c0d5a93d2254ba68bd1ec30d4d4f7e886202639.
This reverts commit 6c0d5a93d2254ba68bd1ec30d4d4f7e886202639.
titom73
force-pushed
the
xaviramon/issue300
branch
from
bda4fba
to
6c6724c
Compare
github-actions
bot
added
the
state: CI Updated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Fixing existing issue with default information originate always on OSPF
Discussion should take place regarding if interfaces must be included in router ospf or not.
Types of changes
Related Issue(s)
Fixes #300
Component(s) name
Proposed changes
How to test
Checklist:
pre-commit,make lintingandmake sanity-lint).