-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor(eos_designs): structured_config for ipv6_static_routes #4986
Open
Vibhu-gslab
wants to merge
3
commits into
aristanetworks:devel
Choose a base branch
from
Vibhu-gslab:refactor_ipv6_static_route
base: devel
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Refactor(eos_designs): structured_config for ipv6_static_routes #4986
Vibhu-gslab
wants to merge
3
commits into
aristanetworks:devel
from
Vibhu-gslab:refactor_ipv6_static_route
+27
−48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4986
# Activate the virtual environment
source test-avd-pr-4986/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/Vibhu-gslab/avd.git@refactor_ipv6_static_route#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/Vibhu-gslab/avd.git#/ansible_collections/arista/avd/,refactor_ipv6_static_route --force
# Optional: Install AVD examples
cd test-avd-pr-4986
ansible-playbook arista.avd.install_examples |
Vibhu-gslab
commented
Feb 6, 2025
python-avd/pyavd/_eos_designs/structured_config/network_services/ipv6_static_routes.py
Outdated
Show resolved
Hide resolved
9bdf79b
to
b1d31d5
Compare
MaheshGSLAB
approved these changes
Feb 10, 2025
MaheshGSLAB
reviewed
Feb 10, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can You cover the other ipv6 static route in this PR.
Base and Inband Management
…es/ipv6_static_routes.py
1243201
to
fc02fd5
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Refactoreos_designs structured_config code for ipv6_static_routes
Related Issue(s)
Fixes #
Component(s) name
arista.avd.eos_designs
Proposed changes
Refactor eos_designs structured_config code for network_services, base and inband_management ipv6_static_routes to use classes
How to test
Checklist
Repository Checklist