Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor(eos_designs): structured_config for ipv6_static_routes #4986

Open
wants to merge 3 commits into
base: devel
Choose a base branch
from

Conversation

Vibhu-gslab
Copy link
Contributor

@Vibhu-gslab Vibhu-gslab commented Feb 6, 2025

Change Summary

Refactoreos_designs structured_config code for ipv6_static_routes

Related Issue(s)

Fixes #

Component(s) name

arista.avd.eos_designs

Proposed changes

Refactor eos_designs structured_config code for network_services, base and inband_management ipv6_static_routes to use classes

How to test

Checklist

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@Vibhu-gslab Vibhu-gslab self-assigned this Feb 6, 2025
Copy link

github-actions bot commented Feb 6, 2025

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4986
# Activate the virtual environment
source test-avd-pr-4986/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/Vibhu-gslab/avd.git@refactor_ipv6_static_route#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/Vibhu-gslab/avd.git#/ansible_collections/arista/avd/,refactor_ipv6_static_route --force
# Optional: Install AVD examples
cd test-avd-pr-4986
ansible-playbook arista.avd.install_examples

@Vibhu-gslab Vibhu-gslab force-pushed the refactor_ipv6_static_route branch 4 times, most recently from 9bdf79b to b1d31d5 Compare February 10, 2025 05:24
@MaheshGSLAB MaheshGSLAB marked this pull request as ready for review February 10, 2025 06:22
@MaheshGSLAB MaheshGSLAB requested review from a team as code owners February 10, 2025 06:22
Copy link
Contributor

@MaheshGSLAB MaheshGSLAB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can You cover the other ipv6 static route in this PR.
Base and Inband Management

@MaheshGSLAB MaheshGSLAB requested review from MaheshGSLAB and a team February 10, 2025 06:31
@Vibhu-gslab Vibhu-gslab force-pushed the refactor_ipv6_static_route branch from 1243201 to fc02fd5 Compare February 10, 2025 11:29
@Vibhu-gslab Vibhu-gslab changed the title Refactor(eos_designs): structured_config for network_services ipv6_static_routes Refactor(eos_designs): structured_config for ipv6_static_routes Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants