Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Collection documentation moved to Read The Doc CDN #528

Merged
merged 4 commits into from
Dec 22, 2020
Merged

Collection documentation moved to Read The Doc CDN #528

merged 4 commits into from
Dec 22, 2020

Conversation

titom73
Copy link
Contributor

@titom73 titom73 commented Dec 21, 2020 •
edited
Loading

Change Summary

Update documentation workflow to support Read The Doc migration

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Documentation content changes
  • Other (please describe):

Related Issue(s)

N/A

Component(s) name

Documentation build

Proposed changes

  • Removed GH workflow to publish on GH pages (not used anymore)
  • Add Link in RN page to related version documentation.

Checklist:

  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed (pre-commit, make linting and make sanity-lint).
  • I have updated molecule CI testing accordingly

@github-actions github-actions bot added type: code quality CI and development toolset type: documentation Improvements or additions to documentation labels Dec 21, 2020
@titom73
Copy link
Contributor Author

titom73 commented Dec 21, 2020

Link for v1.0.x is not available because documentation build is not present in this branch.

@titom73 titom73 changed the title Update documentation workflow to support RTD migration Collection documentation moved to Read The Doc CDN Dec 21, 2020
@github-actions github-actions bot added role: cvp_configlet_upload issue related to cvp_configlet_upload role role: eos_config_deploy_cvp issue related to eos_config_deploy_cvp role state: Documentation role Updated labels Dec 21, 2020
@titom73 titom73 added this to the v1.2.0 milestone Dec 21, 2020
carlbuchmann
carlbuchmann approved these changes Dec 22, 2020
View reviewed changes
Copy link
Member

@carlbuchmann carlbuchmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@carlbuchmann carlbuchmann merged commit 1500ea7 into aristanetworks:devel Dec 22, 2020
@titom73 titom73 mentioned this pull request Dec 22, 2020
Merged
12 tasks
@titom73 titom73 deleted the documentation/rtd-migration branch January 13, 2021 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlbuchmann carlbuchmann carlbuchmann approved these changes

Assignees

@titom73 titom73

Labels
role: cvp_configlet_upload issue related to cvp_configlet_upload role role: eos_config_deploy_cvp issue related to eos_config_deploy_cvp role state: Documentation role Updated type: code quality CI and development toolset type: documentation Improvements or additions to documentation
Projects
None yet
Milestone
v2.0.0rc1
Development

Successfully merging this pull request may close these issues.
2 participants
@titom73 @carlbuchmann