Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUGFIX: No VRF loopback when evpn_services_l2_only is true #535

Merged
merged 1 commit into from
Dec 23, 2020

Conversation

ClausHolbechArista
Copy link
Contributor

@ClausHolbechArista ClausHolbechArista commented Dec 23, 2020

Change Summary

Prevent creation of VRF loopbacks (VTEP Diagnostic interface) when evpn_services_l2_only : true

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Documentation content changes
  • Other (please describe):

Related Issue(s)

Component(s) name

eos_l3ls_evpn

Proposed changes

Add extra condition in template leaf-tenant-vrf-loopbacks.

Using the same condition as in the other tenant templates.

How to test

Tested with claus-l3ls-dev branch superspine-alternative.

After fix it removed VRF loopback from DC1-POD1-LEAF2A/2B

Checklist:

  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed (pre-commit, make linting and make sanity-lint).
  • I have updated molecule CI testing accordingly

@github-actions github-actions bot added the role: eos_l3ls_evpn issue related to eos_l3ls_evpn role label Dec 23, 2020
@ClausHolbechArista ClausHolbechArista added the type: bug Something isn't working label Dec 23, 2020
Copy link
Member

@carlbuchmann carlbuchmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@carlbuchmann carlbuchmann merged commit c627952 into aristanetworks:devel Dec 23, 2020
@titom73 titom73 added this to the v2.0.0rc1 milestone Jan 21, 2021
@ClausHolbechArista ClausHolbechArista deleted the bugfix-l2only branch July 9, 2021 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
role: eos_l3ls_evpn issue related to eos_l3ls_evpn role type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants