Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add explicit no shutdown and switchport config #553

Conversation

ClausHolbechArista
Copy link
Contributor

@ClausHolbechArista ClausHolbechArista commented Dec 29, 2020

Change Summary

In eos_cli_config_gen: Ensure that configurations for no shutdown and switchport are rendered explicitly
In eos_l3ls_evpn: Explicitly set shutdown: false and type: switched instead of relying on expected defaults

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Documentation content changes
  • Other (please describe):

Related Issue(s)

Component(s) name

eos_cli_config_gen
eos_l3ls_evpn

Proposed changes

Shutdown

  • If shutdown: false we now render no shutdown
  • If shutdown: true we still render shutdown
  • If shutdown is not defined we still don't render anything.

This will enable future support for flipping the EOS default to shutdown, protecting unconfigured ports.

Switchport

  • If type: routed we still render no switchport
  • If type: switched we now render switchport
  • If type is not defined we now render switchport

This will enable future support for flipping the EOS default to no switchport, protecting unconfigured ports.

How to test

Tested port-channels, members, switchports, routed ports, shutdown, no shutdown combinations.

Test result here:
https://github.com/ClausHolbechArista/claus-l3ls-dev/commit/39f715e132639b775069c001dc04131b3225dbf5
and after updating l3ls with explicit shutdown:false and type: switched where applicable:
https://github.com/ClausHolbechArista/claus-l3ls-dev/commit/a4d8f5907a9348baf71dc75df4d5cca9e1a4c1ac

Checklist:

  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed (pre-commit, make linting and make sanity-lint).
  • I have updated molecule CI testing accordingly

@github-actions github-actions bot added the role: eos_cli_config_gen issue related to eos_cli_config_gen role label Dec 29, 2020
@github-actions github-actions bot requested a review from aphillipps December 29, 2020 11:46
@ClausHolbechArista
Copy link
Contributor Author

Working on new CI artifacts...

@github-actions github-actions bot added the state: CI Updated CI scenario have been updated in the PR label Dec 29, 2020
@github-actions github-actions bot added the role: eos_l3ls_evpn issue related to eos_l3ls_evpn role label Dec 29, 2020
Copy link
Contributor

@titom73 titom73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Idempotency is still working even if switchport is not displayed in configuration running on EOS.

@titom73 titom73 added this to the v1.2.0 milestone Dec 29, 2020
@ClausHolbechArista
Copy link
Contributor Author

@titom73 I am updating CI again with the latest l3ls changes.

@github-actions github-actions bot requested a review from titom73 December 29, 2020 13:55
Copy link
Contributor

@titom73 titom73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and after running a full l3ls_evpn playbook, the configuration remains idempotent while the generated configuration is explicit.

@ClausHolbechArista ClausHolbechArista merged commit b3e3a32 into aristanetworks:devel Dec 29, 2020
@ClausHolbechArista ClausHolbechArista deleted the config_gen-shutdown-and-switchport branch July 9, 2021 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
role: eos_cli_config_gen issue related to eos_cli_config_gen role role: eos_l3ls_evpn issue related to eos_l3ls_evpn role state: CI Updated CI scenario have been updated in the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants