-
Notifications
You must be signed in to change notification settings - Fork 235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add explicit no shutdown and switchport config #553
Add explicit no shutdown and switchport config #553
Conversation
Working on new CI artifacts... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Idempotency is still working even if switchport
is not displayed in configuration running on EOS.
@titom73 I am updating CI again with the latest l3ls changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and after running a full l3ls_evpn playbook, the configuration remains idempotent while the generated configuration is explicit.
Change Summary
In
eos_cli_config_gen
: Ensure that configurations forno shutdown
andswitchport
are rendered explicitlyIn
eos_l3ls_evpn
: Explicitly setshutdown: false
andtype: switched
instead of relying on expected defaultsTypes of changes
Related Issue(s)
Component(s) name
eos_cli_config_gen
eos_l3ls_evpn
Proposed changes
Shutdown
shutdown: false
we now renderno shutdown
shutdown: true
we still rendershutdown
shutdown is not defined
we still don't render anything.This will enable future support for flipping the EOS default to shutdown, protecting unconfigured ports.
Switchport
type: routed
we still renderno switchport
type: switched
we now renderswitchport
type is not defined
we now renderswitchport
This will enable future support for flipping the EOS default to
no switchport
, protecting unconfigured ports.How to test
Tested port-channels, members, switchports, routed ports, shutdown, no shutdown combinations.
Test result here:
https://github.com/ClausHolbechArista/claus-l3ls-dev/commit/39f715e132639b775069c001dc04131b3225dbf5
and after updating l3ls with explicit
shutdown:false
andtype: switched
where applicable:https://github.com/ClausHolbechArista/claus-l3ls-dev/commit/a4d8f5907a9348baf71dc75df4d5cca9e1a4c1ac
Checklist:
pre-commit
,make linting
andmake sanity-lint
).