Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for logging event under interfaces #570

Merged
merged 3 commits into from
Jan 6, 2021
Merged

Add support for logging event under interfaces #570

merged 3 commits into from
Jan 6, 2021

Conversation

titom73
Copy link
Contributor

@titom73 titom73 commented Dec 30, 2020

Change Summary

Extend data model to support logging event link-status at the interface level.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Documentation content changes
  • Other (please describe):

Related Issue(s)

Fixes #569

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

Extend data model for the following interfaces to support logging event link-status

  • Ethernet
  • Port-Channel

How to test

Use Molecule or insert following YAML in an interface definition

type: routed
logging:
  event:
    link_status: true

Checklist:

  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed (pre-commit, make linting and make sanity-lint).
  • I have updated molecule CI testing accordingly

@titom73 titom73 added this to the v1.2.0 milestone Dec 30, 2020
@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated labels Dec 30, 2020
Copy link
Member

@carlbuchmann carlbuchmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@carlbuchmann carlbuchmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@titom73 titom73 merged commit 74f2878 into aristanetworks:devel Jan 6, 2021
@titom73 titom73 deleted the issues/569 branch January 6, 2021 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add logging under interfaces in eos_cli_config_gen
2 participants