Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bgp: vrf: support originating a default-route #587

Merged
merged 4 commits into from
Jan 11, 2021

Conversation

c-po
Copy link
Contributor

@c-po c-po commented Jan 7, 2021

Change Summary

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Documentation content changes
  • Other (please describe):

Related Issue(s)

#586

Component(s) name

eos_cli_config_gen

Proposed changes

  vrfs:
    < vrf_name_1 >:
      networks:
        < prefix_ipv4 >:
          route_map: < route_map_name >
      neighbors:
        < neighbor_ip_address >:
          default_originate:
            always: < true | false >
            route_map: < route_map_name >

How to test

router_bgp:
  as: 64512
  router_id: 172.16.7.192
  bgp_defaults:
    - bgp log-neighbor-changes
  vrfs:
    AristaFOO:
      rd: 64512:100
      networks:
        10.0.0.0/16:
      neighbors:
        192.168.72.4:
          remote_as: 64535
          timers: "10 30"
          description: MPLS_A
          default_originate:
            always: true

Checklist:

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have updated molecule CI testing accordingly
  • All new and existing tests passed (pre-commit, make linting and make sanity-lint).

@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role state: Documentation role Updated labels Jan 7, 2021
@c-po c-po changed the title Issues/586 bgp: vrf: support originating a default-route Jan 7, 2021
@github-actions github-actions bot added the state: CI Updated CI scenario have been updated in the PR label Jan 7, 2021
@c-po
Copy link
Contributor Author

c-po commented Jan 7, 2021

This is my first PR also updating the molecule tests. I hope I did everything in the manner it should be done @carlbuchmann @titom73 @aphillipps?

@titom73 titom73 linked an issue Jan 7, 2021 that may be closed by this pull request
3 tasks
@titom73
Copy link
Contributor

titom73 commented Jan 7, 2021

From Molecule stand point, it looks like all good and it is helpful to track deviation with result of Molecule CLI CONFIG GEN action.

mkdoc_check error can be ignored and will be resolved with PR #590 and seems to be related to runner issue.

We will shortly review your changes and proceed with a merge

Thanks again for all your contributions!

@c-po
Copy link
Contributor Author

c-po commented Jan 7, 2021

How to do this Molecule CLI CONFIG GEN?

@titom73
Copy link
Contributor

titom73 commented Jan 7, 2021

It is a test action we have in CI like this one

If you want to run the same kind of test, you can do:

$ cd ansible_collections/arista/avd/molecule

$ make run

But from what I see in changed files, I think you run this test before commit.

Copy link
Contributor

@titom73 titom73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for your PR!

Besides that, we have released 2 plugins in the collection which could save time in your templates. Documentation is available in the repo

@titom73 titom73 merged commit 6610d3e into aristanetworks:devel Jan 11, 2021
@titom73 titom73 added this to the v1.2.0 milestone Jan 11, 2021
@c-po c-po deleted the issues/586 branch November 8, 2021 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bgp: vrf: support originating a default-route and network
2 participants