-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bgp: vrf: support originating a default-route #587
Conversation
This is my first PR also updating the molecule tests. I hope I did everything in the manner it should be done @carlbuchmann @titom73 @aphillipps? |
From Molecule stand point, it looks like all good and it is helpful to track deviation with result of
We will shortly review your changes and proceed with a merge Thanks again for all your contributions! |
How to do this |
It is a test action we have in CI like this one If you want to run the same kind of test, you can do:
But from what I see in changed files, I think you run this test before commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thanks for your PR!
Besides that, we have released 2 plugins in the collection which could save time in your templates. Documentation is available in the repo
Change Summary
Types of changes
Related Issue(s)
#586
Component(s) name
eos_cli_config_gen
Proposed changes
How to test
Checklist:
pre-commit
,make linting
andmake sanity-lint
).