Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated QOS section in readme file #588

Merged
merged 1 commit into from
Jan 7, 2021
Merged

Updated QOS section in readme file #588

merged 1 commit into from
Jan 7, 2021

Conversation

onurgashi
Copy link
Contributor

@onurgashi onurgashi commented Jan 7, 2021

Change Summary

Trimmed the QOS section as it's now separated.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Documentation content changes
  • Other (please describe):

Related Issue(s)

Component(s) name

eos_cli_config_gen

readme.md

Proposed changes

How to test

Checklist:

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have updated molecule CI testing accordingly
  • All new and existing tests passed (pre-commit, make linting and make sanity-lint).

@onurgashi onurgashi added type: documentation Improvements or additions to documentation role: eos_cli_config_gen issue related to eos_cli_config_gen role labels Jan 7, 2021
@onurgashi onurgashi self-assigned this Jan 7, 2021
@onurgashi
Copy link
Contributor Author

onurgashi commented Jan 7, 2021

Oddly as we have interface defaults and qos, qos-profile merged earlier, as titles they are not in the readme yet. The content is there though.

Copy link
Contributor

@titom73 titom73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@titom73 titom73 merged commit 8ab88d7 into aristanetworks:devel Jan 7, 2021
@titom73 titom73 added this to the v2.0.0rc1 milestone Jan 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
role: eos_cli_config_gen issue related to eos_cli_config_gen role state: Documentation role Updated type: documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants