Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect send_community for underlay on spines #592

Merged
merged 3 commits into from
Jan 10, 2021
Merged

Fix incorrect send_community for underlay on spines #592

merged 3 commits into from
Jan 10, 2021

Conversation

titom73
Copy link
Contributor

@titom73 titom73 commented Jan 8, 2021

Change Summary

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Documentation content changes
  • Other (please describe):

Related Issue(s)

Component(s) name

eos_l3ls_evpn

Proposed changes

Add send_community configured to true for IPv4-UNDERLAY-PEERS

(Molecule is broken for l3sl_evpn due to PR#151)

Checklist:

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have updated molecule CI testing accordingly
  • All new and existing tests passed (pre-commit, make linting and make sanity-lint).

@github-actions github-actions bot requested a review from carlbuchmann January 8, 2021 17:59
@github-actions github-actions bot added role: eos_l3ls_evpn issue related to eos_l3ls_evpn role state: CI Updated CI scenario have been updated in the PR labels Jan 8, 2021
@titom73 titom73 added this to the v1.2.0 milestone Jan 8, 2021
@titom73
Copy link
Contributor Author

titom73 commented Jan 9, 2021

Needs to be rebased after merging PR #595

@github-actions
Copy link

github-actions bot commented Jan 9, 2021

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the state: conflict PR with conflict label Jan 9, 2021
@github-actions github-actions bot requested a review from aphillipps January 10, 2021 02:34
@github-actions
Copy link

Conflicts have been resolved. A maintainer will review the pull request shortly.

@github-actions github-actions bot removed the state: conflict PR with conflict label Jan 10, 2021
@carlbuchmann carlbuchmann marked this pull request as ready for review January 10, 2021 02:37
carlbuchmann
carlbuchmann approved these changes Jan 10, 2021
View reviewed changes
Copy link
Member

@carlbuchmann carlbuchmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@carlbuchmann carlbuchmann merged commit 7d92c2f into aristanetworks:devel Jan 10, 2021
@titom73 titom73 deleted the features/send-community-underlay branch January 13, 2021 08:23
@titom73
Copy link
Contributor Author

titom73 commented Jan 26, 2021

cherry-picked to pre-release branch: https://github.com/titom73/ansible-avd/tree/release-v1.1.3-preparation

@titom73 titom73 mentioned this pull request Jan 26, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlbuchmann carlbuchmann carlbuchmann approved these changes

@aphillipps aphillipps Awaiting requested review from aphillipps

Assignees

@titom73 titom73

Labels
cherry-pick role: eos_l3ls_evpn issue related to eos_l3ls_evpn role state: CI Updated CI scenario have been updated in the PR
Projects
None yet
Milestone
v2.0.0rc1
Development

Successfully merging this pull request may close these issues.
2 participants
@titom73 @carlbuchmann