make mlag Dual Primary Detection disabled by default

[ksator]

Change Summary

this PR makes mlag Dual Primary Detection disabled by default

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• Code style update (formatting, renaming)
• Refactoring (no functional changes)
• Documentation content changes
• Other (please describe):

Related Issue(s)

#601

Component(s) name

Proposed changes

• mlag Dual Primary Detection was enabled by default (when mlag was enabled).
• this PR makes mlag Dual Primary Detection disabled by default (for L2 leaf and L3 leaf)

How to test

• configure mlag_dual_primary_detection: true l3leaf.defaults or l3leaf.node_groups. or l2leaf.defaults or l2leaf.node_groups.
• run eos_l3ls_evpn role
• check intended structured_config and verify there is this for the appropriate devices

  peer_address_heartbeat:
    peer_ip: 10.73.1.106
    vrf: MGMT
  dual_primary_detection_delay: 5

• then, dont configure mlag_dual_primary_detection
• run eos_l3ls_evpn role
• check intended structured_config and verify there is no

  peer_address_heartbeat:
    peer_ip: 10.73.1.106
    vrf: MGMT
  dual_primary_detection_delay: 5

Checklist:

• My code has been rebased from devel before I start
• I have read the CONTRIBUTING document.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have updated molecule CI testing accordingly
• All new and existing tests passed (pre-commit, make linting and make sanity-lint).

[titom73]

Looks good, but could you update Molecule artifacts to track changes and review result of your changes?

[ksator]

Done (CI updated).

[titom73]

LGTM!