Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid errors on super-spines with L2 interfaces #647

Closed
wants to merge 1 commit into from
Closed

Avoid errors on super-spines with L2 interfaces #647

wants to merge 1 commit into from

Conversation

xaviramon
Copy link
Contributor

Change Summary

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Documentation content changes
  • Other (please describe):

Related Issue(s)

Fixes #552

Component(s) name

Proposed changes

How to test

Checklist:

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have updated molecule CI testing accordingly
  • All new and existing tests passed (pre-commit, make linting and make sanity-lint).

@github-actions github-actions bot added the role: eos_l3ls_evpn issue related to eos_l3ls_evpn role label Jan 21, 2021
@titom73 titom73 added the type: bug Something isn't working label Jan 27, 2021
titom73
titom73 reviewed Jan 27, 2021
View reviewed changes
Copy link
Contributor

@titom73 titom73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@ClausHolbechArista, @onurgashi could you confirm with your super-spine setup ?

@ClausHolbechArista
Copy link
Contributor

ClausHolbechArista commented Jan 27, 2021 •
edited
Loading

This one is no longer relevant with my rewrite.
@titom73

@titom73 titom73 added the duplicate This issue or pull request already exists label Jan 27, 2021
@titom73
Copy link
Contributor

titom73 commented Jan 27, 2021

Will be solved by #655 which has a bigger coverage.

@titom73 titom73 closed this Jan 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@titom73 titom73 titom73 left review comments

@carlbuchmann carlbuchmann Awaiting requested review from carlbuchmann

@aphillipps aphillipps Awaiting requested review from aphillipps

Assignees

@xaviramon xaviramon

Labels
duplicate This issue or pull request already exists role: eos_l3ls_evpn issue related to eos_l3ls_evpn role type: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve Jinja2 templates for super-spines to avoid error in case of unusual config
3 participants
@xaviramon @ClausHolbechArista @titom73