Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ansible-lint and ansible-test lint issues #680

Merged
merged 4 commits into from
Feb 4, 2021
Merged

Fix ansible-lint and ansible-test lint issues #680

merged 4 commits into from
Feb 4, 2021

Conversation

carlbuchmann
Copy link
Member

Change Summary

Remove unused imports in filter plugins, as reported by flake8 tests.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Documentation content changes
  • Other (please describe):

@github-actions github-actions bot added filter: is_in_filter issue related to is_in_filter plugin type: Python filters labels Feb 3, 2021
@carlbuchmann carlbuchmann marked this pull request as draft February 3, 2021 15:47
@carlbuchmann carlbuchmann changed the title Remove unused imports in filter plugins Fix ansible-lint and ansible-test lint issues Feb 3, 2021
@github-actions github-actions bot requested a review from titom73 February 3, 2021 15:54
@github-actions github-actions bot added role: eos_config_deploy_eapi issue related to eos_config_deploy_eapi role role: eos_validate_state labels Feb 3, 2021
@github-actions github-actions bot added the state: CI Updated CI scenario have been updated in the PR label Feb 3, 2021
@titom73 titom73 self-assigned this Feb 3, 2021
@carlbuchmann carlbuchmann marked this pull request as ready for review February 4, 2021 02:22
titom73
titom73 approved these changes Feb 4, 2021
View reviewed changes
Copy link
Contributor

@titom73 titom73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@titom73 titom73 merged commit f170ef7 into aristanetworks:devel Feb 4, 2021
@carlbuchmann carlbuchmann mentioned this pull request Feb 4, 2021
Merged
@carlbuchmann carlbuchmann deleted the fix-lint-issues branch June 25, 2021 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@titom73 titom73 titom73 approved these changes

@ClausHolbechArista ClausHolbechArista Awaiting requested review from ClausHolbechArista

@aphillipps aphillipps Awaiting requested review from aphillipps

@ksator ksator Awaiting requested review from ksator

Assignees

@titom73 titom73

@carlbuchmann carlbuchmann

Labels
filter: is_in_filter issue related to is_in_filter plugin role: eos_config_deploy_eapi issue related to eos_config_deploy_eapi role role: eos_validate_state state: CI Updated CI scenario have been updated in the PR type: Python filters
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@carlbuchmann @titom73